Fix worker_threads support#1110
Open
Qard wants to merge 1 commit intoBlizzard:masterfrom
Open
Conversation
Qard
force-pushed
the
fix-worker-threads
branch
from
006158e to
8071391
Compare
rozzilla
reviewed
Dec 23, 2024
Qard
force-pushed
the
fix-worker-threads
branch
from
8071391 to
3f378cb
Compare
|
@GaryWilber can you take a look? |
Signed-off-by: Stephen Belanger <admin@stephenbelanger.com>
Qard
force-pushed
the
fix-worker-threads
branch
from
3f378cb to
2e2d8ab
Compare
|
Currently, no native-backed Node.js Kafka library seems to support worker threads... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes node-rdkafka work correctly with worker_threads. There were several issues which needed resolving and some changes which were needed to prevent data being shared across threads and to ensure everything is cleaned up completely when the thread exits.
Changes included:
NODE_MODULE_CONTEXT_AWAREto init moduleuv_default_loop(), need to get the loop owned by the current thread.Dispatcher::Deactivate()on destruct to stopuv_async_tso thread can teardown loop safelyConnectionandTopictypes need cleanup hooks to ensure they are deleted when the thread is torn down.Confwith correctly-sized type so destructor and sub-class fields aren't overwriting random memoryAsyncWorkertypes uniqueAsyncResourcenames for better debugging