Conversation
0654239 to
2dbfd60
Compare
2dbfd60 to
0fc2cd9
Compare
lcovar
left a comment
There was a problem hiding this comment.
the wasm functions use .unwrap() which will crash on bad input - wasm-solana and wasm-utxo both return Result<T, Error> instead, can you match that pattern?
|
also validate inputs before processing - bad data (wrong size keys, empty arrays, invalid party_id) will panic instead of returning an error |
| { | ||
| "name": "@bitgo/wasm-mps", | ||
| "description": "Minimal WebAssembly multi-party-schnorr implementation", | ||
| "version": "0.0.1", |
There was a problem hiding this comment.
| "version": "0.0.1", | |
| "version": "0.0.1", | |
| "private": true |
until its ready to be published (some manual work is needed from our devops)
dd91a86 to
ad68856
Compare
You must be looking at the Rust test. The actual functions that are wasm-bound return proper Result types.
I don't think this is the case. I added some unit tests that show the code does not panic with bad inputs. |
Ticket: HSM-1425
ad68856 to
615a29c
Compare
Ticket: HSM-1425