feat(statics): add testToken (SOL) to BitGoJS statics#9326
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Draft
feat(statics): add testToken (SOL) to BitGoJS statics#9326bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Add testToken as a test-only SOL token to @bitgo/statics, including the UnderlyingAsset enum entries, on-chain SPL token factory, and OFC factory. Changes: - modules/statics/src/base.ts: add `tsol:testtoken` (test on-chain) and `sol:testtoken` (mainnet-style key for OFC reference) to the UnderlyingAsset enum - modules/statics/src/coins/solTokens.ts: add tsolToken entry with UUID fcb25a47, mint So111...(Wrapped SOL placeholder), 9 decimals - modules/statics/src/coins/ofcCoins.ts: add ofcsolToken entry with UUID 4b17b883, name ofc:sol:testtoken, 9 decimals This is a dry-run/test token to validate the Linear ticket workflow. The contract address is the well-known Wrapped SOL mint reused as a placeholder — not a real deployment. Ticket: SCAAS-10508 Session-Id: 1f2f5086-425e-4b36-98e8-d4f6db085910 Task-Id: 02c1b714-0b9e-4965-9550-a1054a116828
Contributor
Author
|
@claude please review this PR |
bitgo-ai-agent-dev
Bot
force-pushed
the
feat/SCAAS-10508-sdk-token-add
branch
from
July 22, 2026 11:53
52322ae to
81fdd32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tsol:testtokenandsol:testtokenentries to theUnderlyingAssetenum inmodules/statics/src/base.tstsolToken()entry for the on-chain SPL token inmodules/statics/src/coins/solTokens.ts(UUIDfcb25a47, mintSo111...112, 9 decimals, standard Token Program)ofcsolToken()entry for the OFC coin inmodules/statics/src/coins/ofcCoins.ts(UUID4b17b883, nameofc:sol:testtoken, 9 decimals)Why
Decision log
sol:testtokenadded alongsidetsol:testtoken: The OFC factoryofcsolToken()references anUnderlyingAsset['sol:...']key (mainnet-style), matching the pattern ofofcsol:bils→sol:bilsandofcsol:tshvontesting→sol:tshvontesting. Since this test-only token had no mainnet entry,sol:testtokenwas added per ticket instructions (step 3 note).ofcsolTokenused (nottofcsolToken): The ticket explicitly prescribesofcsolTokenwith nameofc:sol:testtoken. While some existing test OFC SOL tokens usetofcsolTokenwithofctsol:prefix (e.g.ttkb), there is also a precedent forofcsolTokenwith test/staging tokens that live on the SOL mainnet chain config (e.g.ofcsol:tshvontesting). Followed the ticket's explicit instruction.OFC name
ofc:sol:testtokenvs conventionalofcsol:testtoken: The ticket explicitly prescribesofc:sol:testtoken. This deviates from theofcsol:prefix convention used by other entries. Followed the ticket as-written since this is a dry-run; flagging in open questions below.Test plan
npx tsc --noEmit) with no errorsbase.ts,solTokens.ts,ofcCoins.tsOpen questions
ofc:sol:testtokenbut the existing convention forofcsolToken()entries usesofcsol:<token>(e.g.ofcsol:bils). Should this useofcsol:testtokeninstead? Thename.replace(/^ofc/, '')suffix derivation inofc.ts:394would produce:SOL:TESTTOKENwith a leading colon for the prescribed name. This appears to be a ticket authoring issue — please confirm the intended name before merging.Ticket: SCAAS-10508