Skip to content

feat(abstract-utxo): default to psbt-lite for all coin formats #8141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OttoAllmendinger merged 1 commit into from
Feb 13, 2026
+6 −52
Merged

feat(abstract-utxo): default to psbt-lite for all coin formats #8141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions modules/abstract-utxo/src/abstractUtxoCoin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { randomBytes } from 'crypto';
import _ from 'lodash';
import * as utxolib from '@bitgo/utxo-lib';
import { bip32 } from '@bitgo/secp256k1';
import { bitgo, getMainnet, isMainnet } from '@bitgo/utxo-lib';
import { bitgo, getMainnet } from '@bitgo/utxo-lib';
import {
AddressCoinSpecific,
BaseCoin,
Expand Down Expand Up @@ -1001,22 +1001,7 @@ export abstract class AbstractUtxoCoin
return requestedFormat;
}

if (isTestnetCoin(this.name)) {
return 'psbt-lite';
}

const walletFlagMusigKp = wallet.flag('musigKp') === 'true';
const isHotWallet = wallet.type() === 'hot';

// Determine if we should default to psbt format
const shouldDefaultToPsbt =
wallet.subType() === 'distributedCustody' ||
// if mainnet, only default to psbt for btc hot wallets
(isMainnet(this.network) && getMainnet(this.network) === utxolib.networks.bitcoin && isHotWallet) ||
// default to psbt if it has the wallet flag
walletFlagMusigKp;

return shouldDefaultToPsbt ? 'psbt' : undefined;
return 'psbt-lite';
}

async getExtraPrebuildParams(buildParams: ExtraPrebuildParamsOptions & { wallet: Wallet }): Promise<{
Expand Down
39 changes: 4 additions & 35 deletions modules/abstract-utxo/test/unit/txFormat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as assert from 'assert';
import { Wallet } from '@bitgo/sdk-core';

import { AbstractUtxoCoin, ErrorDeprecatedTxFormat, TxFormat } from '../../src';
import { getMainnetCoinName, isMainnetCoin, isTestnetCoin } from '../../src/names';
import { isMainnetCoin, isTestnetCoin } from '../../src/names';

import { utxoCoins, defaultBitGo } from './util';

Expand Down Expand Up @@ -110,42 +110,11 @@ describe('txFormat', function () {
expectedTxFormat: 'psbt-lite',
});

// DistributedCustody wallets default to PSBT (mainnet only, testnet already covered)
// All mainnet wallets default to psbt-lite
runTest({
description: 'should return psbt for distributedCustody wallets on mainnet',
description: 'should return psbt-lite for all mainnet wallets',
coinFilter: (coin) => isMainnetCoin(coin.name),
walletFilter: (w) => w.options.subType === 'distributedCustody',
expectedTxFormat: 'psbt',
});

// MuSig2 wallets default to PSBT (mainnet only, testnet already covered)
runTest({
description: 'should return psbt for wallets with musigKp flag on mainnet',
coinFilter: (coin) => isMainnetCoin(coin.name),
walletFilter: (w) => Boolean(w.options.walletFlags?.some((f) => f.name === 'musigKp' && f.value === 'true')),
expectedTxFormat: 'psbt',
});

// Mainnet Bitcoin hot wallets default to PSBT
runTest({
description: 'should return psbt for mainnet bitcoin hot wallets',
coinFilter: (coin) => isMainnetCoin(coin.name) && getMainnetCoinName(coin.name) === 'btc',
walletFilter: (w) => w.options.type === 'hot',
expectedTxFormat: 'psbt',
});

// Other mainnet wallets do NOT default to PSBT
runTest({
description: 'should return undefined for other mainnet wallets',
coinFilter: (coin) => isMainnetCoin(coin.name),
walletFilter: (w) => {
const isHotBitcoin = w.options.type === 'hot'; // This will be bitcoin hot wallets
const isDistributedCustody = w.options.subType === 'distributedCustody';
const hasMusigKpFlag = Boolean(w.options.walletFlags?.some((f) => f.name === 'musigKp' && f.value === 'true'));
// Only test "other" wallets - exclude the special cases
return !isHotBitcoin && !isDistributedCustody && !hasMusigKpFlag;
},
expectedTxFormat: undefined,
expectedTxFormat: 'psbt-lite',
});

// Test explicitly requested formats
Expand Down