Skip to content

Fix consolidate#8051

Merged
AS195-sketch merged 1 commit intomasterfrom
fix-consolidate
Feb 6, 2026
Merged

Fix consolidate#8051
AS195-sketch merged 1 commit intomasterfrom
fix-consolidate

Conversation

@AS195-sketch
Copy link
Contributor

@AS195-sketch AS195-sketch commented Feb 4, 2026

Issue Ticket: WIN-7796

Issue: insufficient funds error was thrown despite addresses having sufficient funds.

  • occured as the check for balance was compared with 10^7 lovelace (10 ADA) and not 10^6 lovelace (1 ADA)
  • error thrown even if a single address had insufficient (balance - fees) even if wallet had sufficient funds.
  • "missing wallet passphrase" error thrown as wallet passphrase is always excluded in input parameters

Fixes:

  • changed check from 10^7 to 10^6 lovelace
  • skipped addresses with insufficient (balance - fees) to continue the consolidation
  • refactored isUnsignedSweep logic to depend only on the presence of walletPassphrase as checks for user and backup key are already handled

@AS195-sketch AS195-sketch marked this pull request as ready for review February 4, 2026 08:30
@AS195-sketch AS195-sketch requested a review from a team as a code owner February 4, 2026 08:30
Copy link
Contributor

@mullapudipruthvik mullapudipruthvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a commit message with more details

  1. issue
  2. how are you solving it
    also change log would be auto generated afaik

@AS195-sketch AS195-sketch merged commit 55aef4f into master Feb 6, 2026
20 of 21 checks passed
@AS195-sketch AS195-sketch deleted the fix-consolidate branch February 6, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants