Port rest of component wrappers#1697
Closed
NickeZ wants to merge 10 commits intoBitBoxSwiss:masterfrom
Closed
Conversation
NickeZ
force-pushed
the
maint/async-engine-u2f
branch
3 times, most recently
from
9bfb62a to
566c1db
Compare
Instead of relying on the caller to not modify the buffer a copy is made to static memory. This enables the caller to use a stack allocated buffer.
NickeZ
force-pushed
the
maint/async-engine-u2f
branch
6 times, most recently
from
4c13e74 to
f37f299
Compare
ports orientation screen and delay to show that waking works
NickeZ
force-pushed
the
maint/async-engine-u2f
branch
from
f37f299 to
13a2e7a
Compare
benma
reviewed
Feb 6, 2026
benma
reviewed
Feb 7, 2026
benma
reviewed
Feb 7, 2026
benma
reviewed
Feb 11, 2026
| result_cell: &ResultCell<R>, | ||
| ) -> Result<R, Error> { | ||
| component.screen_stack_push(); | ||
| pub async fn with_cancel<F, T, E, GEN>(title: &str, future_generator: GEN) -> Result<T, Error> |
Collaborator
There was a problem hiding this comment.
This rewrite is incorrect. Before, the cancel confirm prompt is added as a component on top of the still-running wrapped component (e.g. showing recovery words), so when rejecting the cancel prompt, you return where you were, e.g. at word number 22 of the recovery words.
With this rewrite, the underlying UI future is dropped and restarted, so customer starts back at the beginning.
Collaborator
|
I believe all of this has now been split into individual PRs and merged, so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port component wrappers to use Futures instead of callbacks