Add toggle for showing number separators and fix a bunch of warnings#649
Open
ILikePlayingGames wants to merge 5 commits intomainfrom
Open
Add toggle for showing number separators and fix a bunch of warnings#649ILikePlayingGames wants to merge 5 commits intomainfrom
ILikePlayingGames wants to merge 5 commits intomainfrom
Conversation
ImRodry
approved these changes
Aug 31, 2022
Collaborator
Author
|
turns out localizing number rendering causes numerous issues, will need additional work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows people to change whether numbers display like
1000or1,000