Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage ? 70.46%
=======================================
Files ? 42
Lines ? 13317
Branches ? 778
=======================================
Hits ? 9384
Misses ? 3928
Partials ? 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings BioFSharp.Mz onto the current BioFSharp stack and replaces the old FAKE 5 build scripts with the build setup used in the BioFSharp repo. Behavior of the library is unchanged. The test suite passes with exactly the same results as before the upgrade.
Dependency upgrade
DynamicObj comes in transitively and resolves to 7.0.1 for both BioFSharp and Plotly.NET.
Code changes
The source migration only adapts renamed or moved APIs. No algorithm, constant or public member was changed.
FastA.fromFileis nowFasta.read, the GFF3 data model moved toBioFSharp.FileFormats.GFF3, the character converter moved toBioItemConverters, and theSelamino acid case is now calledSecOpshelpers are no longer auto opened,Continuous.normalbecameContinuous.Normal.Init, the polynomial regression and linear spline functions got new names, andJaggedArray.transposenow throws on empty input, soidentifyPeaksBygot a small guard that returns the same empty result as beforewithTraceNametowithTraceInfo,Combinetocombine,SaveHtmlAstosaveHtmland so on), the produced charts are unchangedTests
Windows: 231 passed, 0 failed, 54 skipped. That is exactly the baseline from before the upgrade. Linux: 228 passed, 0 failed, 57 skipped, verified on Ubuntu.
Three tests assert Windows specific path behavior and are now skipped on other platforms through a small platform guard. They stay fully active on Windows. Two test helpers that parse chart HTML were adjusted because Plotly.NET 6 nests one more object inside each trace. No expected value or assertion was changed anywhere.
Build and CI
build/, invoked throughbuild.cmdandbuild.sh. Targets include building, tests, coverage, packing and docsbuild.fsx,appveyor.ymland the old deploy workflow are deleted, and the orphanedlib/folder with the checked in fsformatting binaries is removeddeveloperandmain, plus a docs deployment frommainCODECOV_TOKENsecret before it does anythingDocs
The docs folder was reduced to a minimal fsdocs setup: a landing page, the logo and badge images, and the MathJax include.
./build.cmd builddocsbuilds the site with full API references for both projects. Writing actual documentation content is a follow up. The contributing guide was updated to describe the new build and docs workflow.Notes
docs/, same as in the BioFSharp repo, so a source only release does not refresh the published API docsProteinInferenceVisuses a backslash join and therefore only works on Windows. That is pre existing behavior, documented but not changed here