Fix MSTDPET.reset_state_variables to clear p_plus, p_minus, and moving-average buffer - #777
Open
saachigoyall wants to merge 2 commits into
Open
Fix MSTDPET.reset_state_variables to clear p_plus, p_minus, and moving-average buffer#777saachigoyall wants to merge 2 commits into
saachigoyall wants to merge 2 commits into
Conversation
saachigoyall
marked this pull request as ready for review
July 30, 2026 01:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MSTDPET.reset_state_variables(inbindsnet/learning/MCC_learning.py) only zeroedeligibilityandeligibility_trace. It leftp_plus,p_minus, and the moving-average buffer (average_buffer/average_buffer_index) untouched, so callingnetwork.reset_state_variables()did not fully reset an MSTDPET connection's learning state.Motivation
In episodic RL training, this caused state to silently persist across episode boundaries even when the network was explicitly reset between episodes, contaminating the start of each new episode with leftover state from the previous one.
Changes
MSTDPET.reset_state_variablesnow also zerosp_plus,p_minus, and (whenaverage_update > 0)average_buffer, and resetsaverage_buffer_indexto 0.test_mstdpet_reset_clears_moving_average_buffertotest/network/test_learning.py, which builds an MSTDPET connection on aMulticompartmentConnectionwithaverage_updateenabled, runs it long enough to populate all of the above state, callsreset_state_variables(), and asserts everything is zeroed.