Fixes, bug updates and pip upgrades #763
Merged
Merged
Conversation
…TDPET This commit introduces a comprehensive test suite for the reward-modulated learning rules MSTDP and MSTDPET, validating their behavior against a reference implementation based on Florian (2007). The tests cover various aspects including eligibility traces, weight updates, batch handling, and the effects of timing options. Key functionalities tested include: - Exponential decay of the P+ trace - Matching weight updates between the implemented rules and the Florian reference - Causality of STDP sign - Zero lag behavior - Batch processing equivalence to per-sample updates - Compatibility with Conv3d connections The tests ensure that the learning rules function correctly and maintain expected properties across different configurations.
Closed
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
These were committed by accident; .pytest_cache is already gitignored and its cache files (lastfailed, nodeids) churn on every test run. .claude holds local Claude Code settings. Untrack both (kept on disk) and gitignore .claude/. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Resolved a bug where silent neurons defaulted to the first class label. Optimized indexing to prevent unnecessary host-to-device transfers and added robust NaN handling for firing rate proportions.
Reverted variable names to original.
Restored docstring
Switched from '-1' sentinel value for silent neurons to randomly assigned labels. Also added noise for random tie-breaking in neuron assignments.
…d silent neuron assignment logic
Hananel-Hazan
added a commit
that referenced
this pull request
Jun 14, 2026
Merge pull request #763 from BindsNET/hananel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.