Fix per-island health death loop on respawn (#56)#57
Merged
Conversation
With per-island health enabled and a player owning multiple islands, dying on one island softlocked the player in an endless respawn/death loop. Root cause: on death/respawn the player's state is captured mid-death with a health of 0 and saved to the death island's key. When the player later loads that island, Store.setHeath applied the stored 0 via player.setHealth(0), killing them instantly and re-triggering the death screen. Loading a stored health of 0 into a live player is never valid — it only ever arises from a mid-death capture. setHeath now restores full health when the resolved value is <= 0, matching vanilla respawn behaviour, and clamps against max health as before. Adds a regression test covering the fatal-health load case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011i5FDtwcFcJFhbUDSG1YzA
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
Problem
With per-island health enabled and a player owning multiple islands, dying on an island softlocked the player: they respawned at their default island and every attempt to return produced another death screen because their health was stuck at 0.
Root cause
On death/respawn the player's state is captured mid-death (health
0) and saved to the death island's storage key. When the player later loads that island,Store.setHeathapplied the stored0viaplayer.setHealth(0), killing them instantly and re-triggering the death screen — an endless respawn/death loop.A stored health of
0is never a valid value to load into a live player; it can only ever arise from a mid-death capture.Fix
Store.setHeathnow restores full (max) health whenever the resolved value is<= 0, matching vanilla respawn behaviour, and still clamps against max health as before.Testing
StoreTest#testGetInventoryNeverLoadsFatalHealthreproducing the fatal-health load.🤖 Generated with Claude Code