Skip to content

Fix VoteGUI permissions in offline mode #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenCodez merged 2 commits into from
Sep 18, 2026
+83 −5
Merged

Fix VoteGUI permissions in offline mode #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70641af
Fix VoteGUI permissions in offline mode
BenCodez Sep 18, 2026
4d1b7e2
Harden VoteGUI self permission check
BenCodez Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions VotingPlugin/src/main/java/com/bencodez/votingplugin/commands/gui/player/VoteGUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,15 @@ public void onChat(CommandSender sender) {
// not available
}

static String getRequiredPermission(VotingPluginMain plugin, Player player, VotingPluginUser viewedUser) {
VotingPluginUser viewingUser = plugin.getVotingPluginUserManager().getVotingPluginUser(player);
String viewingUuid = viewingUser == null ? null : viewingUser.getUUID();
if (viewingUuid != null && viewedUser != null && viewingUuid.equals(viewedUser.getUUID())) {
return "VotingPlugin.Commands.Vote.GUI";
}
return "VotingPlugin.Commands.Vote.GUI.Other";
}

@Override
public void onChest(Player player) {
if (this.user == null) {
Expand All @@ -190,11 +199,7 @@ public void onChest(Player player) {
inv.dontClose();
}

if (player.getUniqueId().toString().equals(user.getUUID())) {
inv.requirePermission("VotingPlugin.Commands.Vote.GUI");
} else {
inv.requirePermission("VotingPlugin.Commands.Vote.GUI.Other");
}
inv.requirePermission(getRequiredPermission(plugin, player, user));

inv.addPlaceholder("points", "" + user.getPoints());
inv.addPlaceholder("player", user.getPlayerName());
Expand Down
73 changes: 73 additions & 0 deletions ...in/src/test/java/com/bencodez/votingplugin/commands/gui/player/VoteGUIPermissionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
package com.bencodez.votingplugin.commands.gui.player;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

import java.util.UUID;

import org.bukkit.entity.Player;
import org.junit.jupiter.api.Test;

import com.bencodez.votingplugin.VotingPluginMain;
import com.bencodez.votingplugin.user.UserManager;
import com.bencodez.votingplugin.user.VotingPluginUser;

class VoteGUIPermissionTest {

@Test
void ownGuiUsesVotingPluginIdentityWhenOfflineUuidDiffersFromBukkitUuid() {
VotingPluginMain plugin = mock(VotingPluginMain.class);
UserManager userManager = mock(UserManager.class);
Player player = mock(Player.class);
VotingPluginUser viewingUser = mock(VotingPluginUser.class);
VotingPluginUser viewedUser = mock(VotingPluginUser.class);
UUID bukkitUuid = UUID.fromString("11111111-1111-1111-1111-111111111111");
String offlineUuid = "22222222-2222-2222-2222-222222222222";

when(player.getUniqueId()).thenReturn(bukkitUuid);
when(plugin.getVotingPluginUserManager()).thenReturn(userManager);
when(userManager.getVotingPluginUser(player)).thenReturn(viewingUser);
when(viewingUser.getUUID()).thenReturn(offlineUuid);
when(viewedUser.getUUID()).thenReturn(offlineUuid);

assertNotEquals(player.getUniqueId().toString(), viewedUser.getUUID());
assertEquals("VotingPlugin.Commands.Vote.GUI",
VoteGUI.getRequiredPermission(plugin, player, viewedUser));
}

@Test
void nullUserUuidsNeverGrantSelfGuiPermission() {
VotingPluginMain plugin = mock(VotingPluginMain.class);
UserManager userManager = mock(UserManager.class);
Player player = mock(Player.class);
VotingPluginUser viewingUser = mock(VotingPluginUser.class);
VotingPluginUser viewedUser = mock(VotingPluginUser.class);

when(plugin.getVotingPluginUserManager()).thenReturn(userManager);
when(userManager.getVotingPluginUser(player)).thenReturn(viewingUser);
when(viewingUser.getUUID()).thenReturn(null);
when(viewedUser.getUUID()).thenReturn(null);

assertEquals("VotingPlugin.Commands.Vote.GUI.Other",
VoteGUI.getRequiredPermission(plugin, player, viewedUser));
}

@Test
void otherPlayerGuiStillRequiresOtherPermission() {
VotingPluginMain plugin = mock(VotingPluginMain.class);
UserManager userManager = mock(UserManager.class);
Player player = mock(Player.class);
VotingPluginUser viewingUser = mock(VotingPluginUser.class);
VotingPluginUser viewedUser = mock(VotingPluginUser.class);

when(plugin.getVotingPluginUserManager()).thenReturn(userManager);
when(userManager.getVotingPluginUser(player)).thenReturn(viewingUser);
when(viewingUser.getUUID()).thenReturn("22222222-2222-2222-2222-222222222222");
when(viewedUser.getUUID()).thenReturn("33333333-3333-3333-3333-333333333333");

assertEquals("VotingPlugin.Commands.Vote.GUI.Other",
VoteGUI.getRequiredPermission(plugin, player, viewedUser));
}
}
Loading