Remove Maven modules and consolidate into core/Bukkit packages - #77
Merged
Merged
Conversation
…kages Remove the parent and child module builds. Attach shared and shared-sources JARs from the existing POM, retain public compatibility facades, and move all module tests into the normal project. Preserve dependency scopes, versions and shading; verify the packaged shared classpath without adding a workflow.
BenCodez
marked this pull request as ready for review
September 8, 2026 01:49
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged #76, as requested: one normal SimpleAPI project and package-level platform separation, not Maven submodules.
simpleapi-core,simpleapi-configurate, andsimpleapi-sqlmodule directories.SimpleAPI/pom.xmlas the only POM and preservemvn -B -f SimpleAPI/pom.xml package.com.bencodez.simpleapi.core.config, neutral MySQL configuration intocore.sql, and Bukkit configuration entry points intobukkit.config.SimpleAPI-shared.jarandSimpleAPI-shared-sources.jarfrom the same POM and maintained source tree. The normal full JAR remains the existing consumer artifact.SimpleAPI/src/test/java. Reuse existing headless/duration tests rather than duplicating them, and replace standalone probes with ordinary/package-phase tests.No workflow changes
No files under
.github/workflowsare added or modified.shared-libraries.ymlstays removed. There are no automatic cross-repository checkouts, downstream commit pins, version-specific Maven cache paths, or production operations.The existing Maven package command now runs the consolidated unit tests and packaged shared-classpath test from this one project. Forge/Fabric packages will be added when actual adapters exist; this PR does not implement a mod loader.
Compatibility and dependency packaging
The original POM dependency versions/scopes, repositories, publication profiles, and normal shade execution are preserved. Existing full
com.bencodez:simpleapiconsumers need no coordinate/import changes.The former experimental module coordinates are no longer built. Native consumers using them must migrate to classifier
shared, exclude the full artifact's transitive dependencies, and explicitly declare the shared runtime libraries they need. A classifier shares the project POM; it does not have independent dependency metadata. This is documented, including the existing full-JAR versus thin-JAR Hikari relocation distinction.No published artifacts are deleted or remotely published by this PR.
Verified GitHub Actions build
Existing Java CI with Maven — run 195 passed for candidate
16c9e9cca06c59e56d2fdfee5ebc3daec08e8b9b.The
buildjob (101909440029) completed successfully, including its Build with Maven step. Dependency snapshot submission was skipped for the pull-request run. The existing workflow executesmvn -B -f SimpleAPI/pom.xml packagewithout skipping tests.That package lifecycle includes:
SharedArtifactTest, after the full/shared/source JARs exist: platform-reference scanning, shared-class linkage using an isolated runtime classpath, and the native configuration/binding/persistence/SQL fixture.No exact test count is asserted here; the full Maven job's success was verified through the workflow job/step results.
Local verification performed
0bb2b18896c80e27bb1dc0759517313c7354907dexactly..githubchanges.The editing container has Java 21 but no Maven/dependency network access. The full Maven result above is from GitHub Actions, not a local Maven run. No current AdvancedCore/VotingPlugin downstream build, live Minecraft-server test, or live database matrix was run for this PR. Source inspection was same-context; no independent reviewer execution is claimed.
Base:
d5014cd67ce31077881027f998c6925c579437a5.Head:
16c9e9cca06c59e56d2fdfee5ebc3daec08e8b9b.AI disclosure: This implementation and pull-request description were prepared with assistance from ChatGPT.