Skip to content

Remove Maven modules and consolidate into core/Bukkit packages - #77

Merged
BenCodez merged 1 commit into
mainfrom
codex/single-project-platform-packages
Sep 8, 2026
Merged

BenCodez merged 1 commit into
mainfrom
codex/single-project-platform-packages

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-up to merged #76, as requested: one normal SimpleAPI project and package-level platform separation, not Maven submodules.

  • Remove the root parent/aggregator POM and the simpleapi-core, simpleapi-configurate, and simpleapi-sql module directories.
  • Keep SimpleAPI/pom.xml as the only POM and preserve mvn -B -f SimpleAPI/pom.xml package.
  • Move the shared configuration implementations into com.bencodez.simpleapi.core.config, neutral MySQL configuration into core.sql, and Bukkit configuration entry points into bukkit.config.
  • Preserve old public classes as compatibility facades, including constructors, native section identity, covariant section return types, document snapshot view types, and synchronized legacy document operations.
  • Keep existing neutral contracts, annotations, duration/value/JDBC types, and unrelated public APIs in their published packages. This is an incremental organization change, not a breaking rename of every public class.
  • Attach SimpleAPI-shared.jar and SimpleAPI-shared-sources.jar from the same POM and maintained source tree. The normal full JAR remains the existing consumer artifact.
  • Move all former module tests into SimpleAPI/src/test/java. Reuse existing headless/duration tests rather than duplicating them, and replace standalone probes with ordinary/package-phase tests.

No workflow changes

No files under .github/workflows are added or modified. shared-libraries.yml stays removed. There are no automatic cross-repository checkouts, downstream commit pins, version-specific Maven cache paths, or production operations.

The existing Maven package command now runs the consolidated unit tests and packaged shared-classpath test from this one project. Forge/Fabric packages will be added when actual adapters exist; this PR does not implement a mod loader.

Compatibility and dependency packaging

The original POM dependency versions/scopes, repositories, publication profiles, and normal shade execution are preserved. Existing full com.bencodez:simpleapi consumers need no coordinate/import changes.

The former experimental module coordinates are no longer built. Native consumers using them must migrate to classifier shared, exclude the full artifact's transitive dependencies, and explicitly declare the shared runtime libraries they need. A classifier shares the project POM; it does not have independent dependency metadata. This is documented, including the existing full-JAR versus thin-JAR Hikari relocation distinction.

No published artifacts are deleted or remotely published by this PR.

Verified GitHub Actions build

Existing Java CI with Maven — run 195 passed for candidate 16c9e9cca06c59e56d2fdfee5ebc3daec08e8b9b.

The build job (101909440029) completed successfully, including its Build with Maven step. Dependency snapshot submission was skipped for the pull-request run. The existing workflow executes mvn -B -f SimpleAPI/pom.xml package without skipping tests.

That package lifecycle includes:

  • The original unit suite and the tests moved from the former modules.
  • Real Bukkit/core scalar, list, and SQL configuration parity checks.
  • Compatibility-facade tests for section identity, covariant returns, custom separators, and document snapshots.
  • Package-phase SharedArtifactTest, after the full/shared/source JARs exist: platform-reference scanning, shared-class linkage using an isolated runtime classpath, and the native configuration/binding/persistence/SQL fixture.

No exact test count is asserted here; the full Maven job's success was verified through the workflow job/step results.

Local verification performed

  • Reconstructed baseline POM matched upstream blob 0bb2b18896c80e27bb1dc0759517313c7354907d exactly.
  • XML parsing and comparison of dependencies, repositories, versions, profiles, and the full shade execution: passed.
  • Changed-file whitespace checks: passed.
  • Java 21 compilation of relocated binder/SQL configuration implementations and their legacy facades against the previous API JARs: passed.
  • A client compiled separately against the previous binder and SQL configuration APIs ran successfully against the new implementations/facades without recompilation. This checks that selected API surface, not every downstream call.
  • The moved binder algorithm and YAML persistence body were compared with the baseline; their logic is unchanged.
  • Published POM/core files match locally inspected bytes.
  • Git tree/commit comparison confirms removal of the parent/module directories and no .github changes.

The editing container has Java 21 but no Maven/dependency network access. The full Maven result above is from GitHub Actions, not a local Maven run. No current AdvancedCore/VotingPlugin downstream build, live Minecraft-server test, or live database matrix was run for this PR. Source inspection was same-context; no independent reviewer execution is claimed.

Base: d5014cd67ce31077881027f998c6925c579437a5.
Head: 16c9e9cca06c59e56d2fdfee5ebc3daec08e8b9b.

AI disclosure: This implementation and pull-request description were prepared with assistance from ChatGPT.

…kages

Remove the parent and child module builds. Attach shared and shared-sources JARs
from the existing POM, retain public compatibility facades, and move all module
tests into the normal project. Preserve dependency scopes, versions and shading;
verify the packaged shared classpath without adding a workflow.
@BenCodez
BenCodez marked this pull request as ready for review September 8, 2026 01:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T01:53:54.240482Z 16c9e9c Draft marked ready
🔒 Security Review Completed 2026-09-08T01:55:16.774417Z 16c9e9c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@BenCodez
BenCodez merged commit 2764b7f into main Sep 8, 2026
5 checks passed
@BenCodez
BenCodez deleted the codex/single-project-platform-packages branch September 8, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant