Skip to content

Create snippet for Material Autocomplete is outdated (mat-autocomplete and mat-autocomplete$) #114

Description

@sultanmyrza

current auto generated code for mat-autocomplete is outdated

actual

<mat-input-container floatPlaceholder="always">
    <input matInput placeholder="" [matAutocomplete]="autocompleteTemplateRefId"
           formControlName="formControlName">
</mat-input-container>

<mat-autocomplete #autocompleteTemplateRefId="matAutocomplete"
                  [displayWith]="onSelectConvertValueToInputFn">
    <mat-option *ngFor="let choice of choices | async" [value]="choice">
        Choice shown in dropdown
    </mat-option>
</mat-autocomplete>

expected

<mat-form-field floatLabel="always">
    <input matInput placeholder="" [matAutocomplete]="autocompleteTemplateRefId"
           formControlName="formControlName">
</mat-form-field>

<mat-autocomplete #autocompleteTemplateRefId="matAutocomplete"
                  [displayWith]="onSelectConvertValueToInputFn">
    <mat-option *ngFor="let choice of choices | async" [value]="choice">
        Choice shown in dropdown
    </mat-option>
</mat-autocomplete>

now instead mat-input-container we use mat-form-field
because breaking changes
https://github.com/angular/components/blob/master/CHANGELOG.md#600-beta5-2018-03-23

and for floatPlaceholder we use floatLabel
more info https://stackoverflow.com/a/48540947

I really enjoy using these code snippets please fix as soon as possible or let me know how can I fix myself and create pull-request

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions