Clarify updater phases and recovery - #38
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e2552b755
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| updaterProblemInstallFailed: | ||
| 'The update could not be installed. Retry; if the problem continues, reopen the app and check again.', | ||
| updaterProblemRestartFailed: | ||
| 'Automatic restart failed, but BazaarPlusPlus {version} is installed. Quit BazaarPlusPlus Installer, then open it again from Applications.', |
There was a problem hiding this comment.
Use platform-neutral restart recovery copy
When the Windows updater path reaches the new restart-failure state, this same localized message is shown after impl.isWindows() and relaunch() rejects. In that scenario Windows users are told to reopen the app from “Applications”, which is macOS-only and leaves them with incorrect recovery instructions; split the restart failure copy by platform or make it neutral enough for both Windows and macOS.
Useful? React with 👍 / 👎.
Summary
Testing
npm run checknpx vitest run src/features/about/updater.test.ts src/features/about/updaterProblems.test.ts src/features/about/updaterPresentation.test.ts src/layouts/ShellUpdateModal.test.tsx src/layouts/ShellHeader.test.tsxnpm run test:unitnpm run verify -- --source-onlyCloses #29
Release Notes: