Skip to content
This repository was archived by the owner on Sep 20, 2026. It is now read-only.

Clarify updater phases and recovery - #38

Merged
cauyxy merged 2 commits into
masterfrom
yxinyux/issue-29-updater-recovery
Jul 18, 2026
Merged

cauyxy merged 2 commits into
masterfrom
yxinyux/issue-29-updater-recovery

Conversation

@cauyxy

@cauyxy cauyxy commented Jul 18, 2026

Copy link
Copy Markdown
Member

Summary

  • model checking, available, downloading, installing, ready-to-restart, restarting, and failed updater phases explicitly
  • derive shell status, modal actions, priority, and dismissal policy from one updater snapshot
  • replace native error copy with localized semantic updater problems and manual restart recovery
  • expose determinate and indeterminate download progress accessibly
  • update updater truth documentation and focused behavior coverage

Testing

  • npm run check
  • npx vitest run src/features/about/updater.test.ts src/features/about/updaterProblems.test.ts src/features/about/updaterPresentation.test.ts src/layouts/ShellUpdateModal.test.tsx src/layouts/ShellHeader.test.tsx
  • npm run test:unit
  • npm run verify -- --source-only
  • Browser Preview: English/Chinese check status, timed recovery, focus, modal count, and horizontal overflow
  • macOS Tauri smoke: startup detection completed; current 4.5.0 updater manifest reachable; frontend, overlay, and settings returned HTTP 200

Closes #29

Release Notes:

  • 应用更新现在提供清晰的下载、安装与重启阶段,并在失败时给出本地化恢复指引。

@cauyxy
cauyxy merged commit 6d3a43d into master Jul 18, 2026
2 of 4 checks passed
@cauyxy
cauyxy deleted the yxinyux/issue-29-updater-recovery branch July 18, 2026 19:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e2552b755

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/i18n/messages.ts
updaterProblemInstallFailed:
'The update could not be installed. Retry; if the problem continues, reopen the app and check again.',
updaterProblemRestartFailed:
'Automatic restart failed, but BazaarPlusPlus {version} is installed. Quit BazaarPlusPlus Installer, then open it again from Applications.',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use platform-neutral restart recovery copy

When the Windows updater path reaches the new restart-failure state, this same localized message is shown after impl.isWindows() and relaunch() rejects. In that scenario Windows users are told to reopen the app from “Applications”, which is macOS-only and leaves them with incorrect recovery instructions; split the restart failure copy by platform or make it neutral enough for both Windows and macOS.

Useful? React with 👍 / 👎.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

完善更新流程的阶段反馈与恢复路径

1 participant