Degrade Stream by capability - #35
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 622adb8e09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| !this.isCurrentLifecycle(lifecycle) || | ||
| epoch !== this.statusEpoch || | ||
| request < this.latestSuccessfulPollRequest | ||
| ) | ||
| return; | ||
| request !== this.latestPollRequest |
There was a problem hiding this comment.
Count slow poll failures before keeping status fresh
When getStatus() failures take longer than the 2s polling interval, each later interval increments latestPollRequest before the earlier request rejects, so this guard discards every failed response as outdated. With no newer successful status, consecutivePollFailures never reaches the threshold and the snapshot stays fresh, leaving running-only controls enabled against an actually stale service state; the failure path should ignore only failures older than a newer success, not older than any newer request.
Useful? React with 👍 / 👎.
Summary
Testing
Closes #26
Release Notes: