[arnelirobles]

A non-ok response that retryOn rejects (4xx by default) now propagates as an error instead of being caught and retried by the catch block. The catch only consults retryOn for transport and timeout errors. A caller-supplied AbortSignal now aborts the request and is never retried, no attempt starts after the abort, and its listener is removed when each attempt finishes.

Closes #3

- test: packages/resilient-fetcher/src/index.test.ts "does not retry on 4xx by default"
  breaks: packages/resilient-fetcher/src/index.ts "if (error instanceof HttpStatusError) {"
- test: packages/resilient-fetcher/src/index.test.ts "does not retry on 4xx by default"
  breaks: packages/resilient-fetcher/src/index.ts "throw new HttpStatusError(response.status);"
- test: packages/resilient-fetcher/src/index.test.ts "already aborted caller signal makes no fetch call"
  breaks: packages/resilient-fetcher/src/index.ts "throw callerSignal.reason ?? new DOMException("
- test: packages/resilient-fetcher/src/index.test.ts "caller abort stops the request and is not retried"
  breaks: packages/resilient-fetcher/src/index.ts "if (callerSignal?.aborted) {"
- untested: packages/resilient-fetcher/src/index.ts #1
  why: listener removal in the finally block has no observable effect in a mocked fetch test

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn