Skip to content

Two gates from the barakocms.com rebuild: typed claims, and fallbacks that look real - #19

Open
arnelirobles wants to merge 1 commit into
mainfrom
delivery/typed-claims-and-silent-fallbacks
Open

Two gates from the barakocms.com rebuild: typed claims, and fallbacks that look real#19
arnelirobles wants to merge 1 commit into
mainfrom
delivery/typed-claims-and-silent-fallbacks

Conversation

@arnelirobles

@arnelirobles arnelirobles commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Two gates from rebuilding barakocms.com today. Both caught something real, both are cited in the
section, and one of them caught it in production.

A number typed into a page is a claim nothing checks. The site's design said "thirteen modules,
all at 4.0.0". The repo had fourteen module projects, NuGet had a different thirteen (it named
BarakoCMS.Email.Smtp, never published, and omitted BarakoCMS.Files.S3, which is), and the published
core was 3.21.0 with every module on 0.x. The export check was grep -q "barakocms-module", which
passes whether the page says thirteen or thirty, so a page of wrong numbers built clean and passed
every gate. A person reading nuget.org caught it, which is the definition of a missing mechanism.

The part worth keeping is the follow-on: the first version of the script that replaced that person
could not fire on the markup it existed for, because it required the package id and version on one
line and the card puts them on two. It was called verified after only the other half had been
exercised. Rewritten, it immediately found four more typed claims nobody had looked at.

A fallback that renders identically to the real thing. The changelog credits contributors from
the commits API. Unauthenticated GitHub allows 60 requests an hour per IP, that budget was spent,
the build warned and fell back as designed, and the site went live with every contributor missing.
Green build, successful deploy, nobody reads the log. A warning is not a gate: either the page says
it is degraded or the build fails.

Verified: em dash count 0, the document still parses as markdown, and no existing section changed.
Left the "Applied to these repos, 17 August 2026" table alone rather than backdating a row into a
dated audit.

Summary by CodeRabbit

  • Documentation
    • Added guidance for validating project figures—such as counts, versions, and download totals—directly from source data during builds.
    • Documented build checks that flag likely hardcoded figures and require alignment with the page’s markup.
    • Clarified that pages using fallback content after a failed build-time fetch must visibly indicate their degraded state.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: b1bb61c3-bc41-46b1-bf91-1c3362e0801e

📥 Commits

Reviewing files that changed from the base of the PR and between 60e4730 and e57a493.

📒 Files selected for processing (1)
  • DELIVERY.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Delivery gates

Layer / File(s) Summary
Build-time figure validation
DELIVERY.md
Documents fetching project figures from source data at build time and failing the build when markup contains literal-looking figures.
Visible degraded-state reporting
DELIVERY.md
Documents the requirement for pages to show a degraded state when an allowed build-time fetch fails.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e57a4

This documentation change clarifies validation and degraded-state expectations without altering runtime behavior or deployment configuration. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the two main changes: typed-claims validation and visible handling of realistic fallbacks during the barakocms.com rebuild.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch delivery/typed-claims-and-silent-fallbacks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant