Two gates from the barakocms.com rebuild: typed claims, and fallbacks that look real - #19
Open
arnelirobles wants to merge 1 commit into
Open
Two gates from the barakocms.com rebuild: typed claims, and fallbacks that look real#19arnelirobles wants to merge 1 commit into
arnelirobles wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesDelivery gates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This documentation change clarifies validation and degraded-state expectations without altering runtime behavior or deployment configuration. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gates from rebuilding barakocms.com today. Both caught something real, both are cited in the
section, and one of them caught it in production.
A number typed into a page is a claim nothing checks. The site's design said "thirteen modules,
all at 4.0.0". The repo had fourteen module projects, NuGet had a different thirteen (it named
BarakoCMS.Email.Smtp, never published, and omitted BarakoCMS.Files.S3, which is), and the published
core was 3.21.0 with every module on 0.x. The export check was
grep -q "barakocms-module", whichpasses whether the page says thirteen or thirty, so a page of wrong numbers built clean and passed
every gate. A person reading nuget.org caught it, which is the definition of a missing mechanism.
The part worth keeping is the follow-on: the first version of the script that replaced that person
could not fire on the markup it existed for, because it required the package id and version on one
line and the card puts them on two. It was called verified after only the other half had been
exercised. Rewritten, it immediately found four more typed claims nobody had looked at.
A fallback that renders identically to the real thing. The changelog credits contributors from
the commits API. Unauthenticated GitHub allows 60 requests an hour per IP, that budget was spent,
the build warned and fell back as designed, and the site went live with every contributor missing.
Green build, successful deploy, nobody reads the log. A warning is not a gate: either the page says
it is degraded or the build fails.
Verified: em dash count 0, the document still parses as markdown, and no existing section changed.
Left the "Applied to these repos, 17 August 2026" table alone rather than backdating a row into a
dated audit.
Summary by CodeRabbit