Skip to content

fix(test): race-aware sizing for two timing-sensitive tests #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkyberneees merged 1 commit into from
Oct 18, 2026
Merged

fix(test): race-aware sizing for two timing-sensitive tests #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/odek/redhunt_2026_10_17_runs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ func TestRED_RunsFinishedRunPinsAgentAndSession(t *testing.T) {
t.Cleanup(resetServeRuns)

// One large prior turn in the session (well under the 32 MiB file cap).
// The heap check below is skipped under -short and -race, so only it
// needs the large payload; under -race a 6 MiB turn outlives the run wait.
payload := 6 << 20
if testing.Short() {
if testing.Short() || raceEnabled {
payload = 64 << 10
}
sess, err := env.store.Create([]session.Message{
Expand All @@ -129,7 +131,7 @@ func TestRED_RunsFinishedRunPinsAgentAndSession(t *testing.T) {
base := measure()

runs := 4
if testing.Short() {
if testing.Short() || raceEnabled {
runs = 1
}
var finished []*serveRun
Expand Down
3 changes: 2 additions & 1 deletion internal/redact/redhunt_2026_10_12b_ops_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ func TestRED_RedactCredentialNamesScaleLinearly(t *testing.T) {
if large > 9*small {
t.Errorf("%s: super-linear: 64KiB %v, 256KiB %v", name, small, large)
}
if !testing.Short() && ops12bTime(gen(1<<20)) > 10*time.Second {
// Wall-clock budget only without the race detector (5-10x slower).
if !raceEnabled && !testing.Short() && ops12bTime(gen(1<<20)) > 10*time.Second {
t.Errorf("%s: 1 MiB too slow", name)
}
}
Expand Down
Loading