Document TC39 decorators migration breaking changes (9.15.0)#1595
Draft
RaananW wants to merge 1 commit into
Draft
Document TC39 decorators migration breaking changes (9.15.0)#1595RaananW wants to merge 1 commit into
RaananW wants to merge 1 commit into
Conversation
Babylon.js 9.15.0 moved from experimentalDecorators to standard TC39 Stage 3 decorators. Document the consumer impact: compile with experimentalDecorators:false, add the accessor keyword to fields using @expandToProperty/@addAccessorsForMaterialProperty, target ES2015+, use GetEditableProperties() instead of reading _propStore, and the UMD ES5->ES2015 bundle target change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Documentation snapshot uploaded. Snapshot: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1595/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Babylon.js 9.15.0 migrated from TypeScript's legacy
experimentalDecoratorsto standard TC39 Stage 3 decorators (core PRs #18631, #18630, #18647).This adds a
## 9.15.0entry tocontent/breaking-changes.mddocumenting the consumer impact for anyone who applies Babylon.js decorators (@serialize,@expandToProperty,@addAccessorsForMaterialProperty,@editableInPropertyPage, etc.) to their own subclasses:experimentalDecorators: false(TC39 calling convention).accessorkeyword to fields decorated with the auto-accessor decorators (@expandToProperty,@addAccessorsForMaterialProperty); plain field decorators like@serializeare unchanged.ES2015+ (required byaccessor).GetEditableProperties(target)instead of reading the internal_propStore.Additive change only (50 insertions, existing CRLF line endings preserved).