ci(craft): add github target so releases cut a GH release alongside npm - #38
Merged
Conversation
The npm target alone cuts the npm tag via OIDC trusted publishing but no GitHub release. Add the github target so a successful release surfaces as a normal GH release with the npm tarball attached.
Contributor
|
2 tasks
BYK
added a commit
to getsentry/cli
that referenced
this pull request
Jul 31, 2026
Pulls in the synchronous output fd release from [BYK/binpatch#37](BYK/binpatch#37) — `applyReaderToFile` now closes the output fd via `fs.closeSync` before returning, eliminating the ETXTBSY race that broke the delta-upgrade → full-download fallback on Linux. Verified locally: - `pnpm --filter sentry run typecheck` — clean - `pnpm --filter sentry run test:unit` — 8754 passed | 15 skipped Also depends on [BYK/binpatch#38](BYK/binpatch#38) (adds the github target to .craft.yml — internal change, no runtime impact).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a github target to .craft.yml so a successful release via the
Releaseworkflow surfaces as a normal GitHub release with thenpm-tarballCI artifact attached. The npm target alone cuts thenpm tag via OIDC trusted publishing but no GH release — making it
hard to find older releases from the GH UI.