ci(test): build and run external example#376
Open
plexoos wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI validation step to ensure the built Docker image can compile and execute the repository’s example project (intended to validate “external consumer” usage via find_package(simphony)).
Changes:
- Introduce a new workflow step that builds the CMake project under
examples/inside the PR’s Docker image. - Run the built example and assert it produces an expected output file (
out/photons.npy).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e94ccaef0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
plexoos
force-pushed
the
build-example
branch
3 times, most recently
from
a619dde to
c9c0c8b
Compare
Comment on lines
+21
to
+24
| cmake -S . -B build | ||
| cmake --build build | ||
| ./simphox | ||
| ./simphox --gpu |
Comment on lines
+33
to
+36
| else if (arg == "--num-photons" && i + 1 < argc) | ||
| { | ||
| num_photons = static_cast<unsigned int>(stoul(argv[++i])); | ||
| } |
Comment on lines
+46
to
+56
| sphoton* d_photons = nullptr; | ||
| CUDA_CHECK(cudaMalloc(reinterpret_cast<void**>(&d_photons), photons.size() * sizeof(sphoton))); | ||
|
|
||
| constexpr unsigned int threads_per_block = 256; | ||
| unsigned int blocks = (num_photons + threads_per_block - 1) / threads_per_block; | ||
|
|
||
| generate_photons_kernel<<<blocks, threads_per_block>>>(torch, d_photons, num_photons, seed); | ||
| CUDA_SYNC_CHECK(); | ||
|
|
||
| CUDA_CHECK(cudaMemcpy(photons.data(), d_photons, photons.size() * sizeof(sphoton), cudaMemcpyDeviceToHost)); | ||
| CUDA_CHECK(cudaFree(d_photons)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CI coverage for the standalone
simphoxexternal-consumer example and expands the example so it can smoke-test both CPU and CUDA photon generation.Changes include:
simphoxintoexamples/simphox/as a standalone CMake project.simphox --gpu; CPU remains the default.simphox --cpuandsimphox --gpuin PR CI against the installed Simphony package.glminsimphonyConfig.cmakesrng_traits.hinstall entrysquad.hinclude fromstorch.hexamples/README.mdto documentsimphoxas Example 1 and renumber the existing examples.Testing
examples/simphoxout-of-tree withfind_package(simphony REQUIRED).simphox --cpusimphox --gpuout/photons.npyis produced.