Conversation
At the set resolution, it causes a PANIC
BitterB0NG0
left a comment
BitterB0NG0
left a comment
There was a problem hiding this comment.
Since the code still builds and my inline comments refer to readability changes, the four commits in "HAGL" may merge into "main." However, the code should change according to my comments as well.
| * while the LED is off. This is used to gate the reporter task and keep it | ||
| * from printing. | ||
| */ | ||
| void blinker(void) { |
There was a problem hiding this comment.
If the "blinker(void)" function has been removed to attach the screen hardware component, its not clear what Raspberry Pi Pico W pins are devoted to what inputs/outputs. "blinker(void)" could continue to demonstrate functionality with different pins later and be commented out of compilation and execution.
This comment applies to the "blinker(void)" and "reporter_task(void)" functions.
There was a problem hiding this comment.
The screen pins are seen in the cmakelists.txt file within the os folder. The hardware library requires it to be so, but I believe that I might remove this graphics library in the future.
There was a problem hiding this comment.
The blinker feature actually makes sense and should be added back into the os.
2 participants
No description provided.