Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR adds a small CSS override block to each generated notebook HTML page during the Pages build.
Why it changed
The notebook pages are rendering on a light background, but some notebook and ANSI/text output styles can still appear too light, which makes parts of the page hard to read.
User impact
Rendered notebook pages should keep a readable light theme with darker body text, output text, and safer ANSI color handling.
Root cause
The nbconvert/Jupyter CSS bundle brings its own theme variables and output color classes. On the live Pages site, some of those styles were still producing low-contrast text against the white page background.
Validation
I inspected the live notebook HTML at
Math-Lessons.htmland found Jupyter output/ANSI classes such as.ansi-white-fg,.ansi-white-intense-fg, and inverse foreground styles in the generated page CSS. I then added a post-processing CSS injection inbuild_pages.pyto force a readable light-theme palette for generated notebook pages.