Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes the failing Chinese translation workflow and hardens the translation script so the workflow can run reliably.
Root cause
The current workflow calls
python translate-notebooks.py, but the repository file is namedtranslate_notebooks.py. The latest failure on April 9, 2026 stopped immediately with:python: can't open file '/home/runner/work/MathLearningNotes/MathLearningNotes/translate-notebooks.py': [Errno 2] No such file or directoryAdditional fixes included
pull_requestfor validation, but only push translated notebook updates on non-PR runs.translated-notebooksactually changed.translated-notebooksto avoid recursive retranslation.Validation
24190258737and confirmed the filename mismatch from the job log.translate_notebooks.pylocally.