fix: resolve critical security vulnerabilities (21→9 vulnerabilities)#962
Closed
keith-oak wants to merge 1 commit intoAzure:mainfrom
keith-oak:fix-security-vulnerabilities
Closed
fix: resolve critical security vulnerabilities (21→9 vulnerabilities)#962keith-oak wants to merge 1 commit intoAzure:mainfrom keith-oak:fix-security-vulnerabilities
keith-oak wants to merge 1 commit intoAzure:mainfrom
keith-oak:fix-security-vulnerabilities
Conversation
- Reduced vulnerabilities from 21 to 9 (57% reduction) - Fixed all critical vulnerabilities including CVE-2024-47764 - Updated cookie (^0.5.0 → ^0.7.0) and vitest (^2.0.2 → ^2.1.9) - Applied npm audit fix for automatic security updates - All tests pass, no breaking changes introduced Remaining vulnerabilities require major version updates and should be addressed separately.
This was referenced Jun 25, 2025
LongOddCode
added a commit
that referenced
this pull request
Apr 21, 2026
cookie < 0.7.0 is vulnerable to CVE-2024-47764 (CVSS 9.1, Critical): malicious cookie values can inject unexpected object keys like __proto__/constructor/prototype, enabling prototype pollution. Resolved to cookie@0.7.2 in the lockfile. The package's serialize()/parse() signatures used in src/core/utils/cookie.ts are unchanged in 0.7.x, so this is a drop-in replacement. Reviving the fix after the prior attempts (#960, #962) were closed without explanation; issue #932 is still open. The additional lockfile churn is npm's standard peer-marker drift when regenerating the tree — no other package versions changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical security vulnerabilities by updating dependencies, reducing total vulnerabilities from 21 to 9 (57% reduction).
cookie < 0.7.0#932 (Vulnerable dependencycookie < 0.7.0)Security Impact
Before
After
Changes Made
Manual updates for critical issues:
cookie: ^0.5.0 → ^0.7.0 (fixes CVE-2024-47764)vitest: ^2.0.2 → ^2.1.9 (fixes RCE vulnerability)Automated security fixes via
npm audit fix:Testing
Remaining Vulnerabilities
The 9 remaining vulnerabilities require major version updates with potential breaking changes:
These should be addressed in separate PRs with dedicated testing.
Related PRs
Benefits
This PR provides immediate security improvements without breaking changes, making it safe to merge quickly while planning for the remaining major updates.