-
Notifications
You must be signed in to change notification settings - Fork 308
Add internal text embedding system #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robertopc1
wants to merge
23
commits into
Azure:main
Choose a base branch
from
robertopc1:add-internal-text-embedding-system
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0dc589e
Initial plan
Copilot d3187bd
Add EmbeddingsOptions and EmbeddingProviderType configuration models
Copilot 6064826
Add CLI configure options for embeddings and register embedding service
Copilot 0653f15
Add unit tests for embeddings and update JSON schema with embeddings …
Copilot 21e81b9
Simplify HttpClient registration for embedding service
Copilot 0cd8e53
Plan for embedding service enhancements
Copilot 7fa1c49
Refactor embedding code into dedicated namespaces
Copilot c3f6937
Fix property renames and update tests
Copilot 1e18c25
Add EmbeddingsOptionsConverter and fix all tests
Copilot 857203a
Address code review feedback
Copilot 89cb2d9
Address PR feedback: Add Azure OpenAI validation, cache key security,…
Copilot 64b592e
Optimize ProviderName to avoid repeated string allocations
Copilot e8d7238
Fix schema mismatch, remove unused field, add enabled handling, valid…
Copilot d9c8a29
Add embedding health check execution and update JSON schema with endp…
Copilot 3e02c0f
Add EmbeddingController for /embed REST endpoint with role-based auth…
Copilot 5c05464
Address code review feedback for EmbeddingController
Copilot c9eba20
fix: manually deserialize EmbeddingsEndpointOptions and EmbeddingsHea…
robertopc1 d3a5209
feat: add embeddings config validation and unit tests
robertopc1 203e232
Update src/Core/Services/Embeddings/EmbeddingService.cs
robertopc1 2cb3999
Update src/Config/Converters/EmbeddingsOptionsConverterFactory.cs
robertopc1 b432e4f
Update src/Service/Startup.cs
robertopc1 a8442f4
Taking care of feedback
robertopc1 a301290
Merge branch 'main' into add-internal-text-embedding-system
robertopc1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a change in what we originally discussed but embedding enabled needs to default to false to minimize the surface area exposed. With constraints that if this is true then the other settings are required will make this default necessary. Anyway, default should be
false.