This repository was archived by the owner on May 8, 2024. It is now read-only.
#295 Add missing x-ms-blob-type header to createFile and createFileFromContents requests#296
Open
bimsonz wants to merge 4 commits intoAzure:masterfrom
Open
#295 Add missing x-ms-blob-type header to createFile and createFileFromContents requests#296bimsonz wants to merge 4 commits intoAzure:masterfrom
bimsonz wants to merge 4 commits intoAzure:masterfrom
Conversation
|
|
Author
|
@katmsft any chance you or one of your colleagues could have a look at this please? |
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 296 in repo Azure/azure-storage-php |
Author
|
@XiaoningLiu any chance you or one of your colleagues could have a look at this please? |
Member
|
I think this is a usage error on file service instead of the blob service for block blob. Are you trying to use it for ADLS Gen 2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #295 to the best of my knowledge.
I've removed headers that make the request fail, these could be required and the configuration could be missing elsewhere but this was the success I had testing and fixing this with limited knowledge of the blob storage api.
I've also added the additional and seemingly missing
x-ms-blob-typeheader. The value is fixed toBlockBlobas this felt most appropriate for this operation based on https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blobs-introduction#blobs