Skip to content

[AutoPR azure-mgmt-webpubsub]-generated-from-SDK Generation - Python-6783650 - #48881

Open
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-webpubsub-6783650
Open

[AutoPR azure-mgmt-webpubsub]-generated-from-SDK Generation - Python-6783650#48881
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-webpubsub-6783650

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/webpubsub/resource-manager/Microsoft.SignalRService/SignalRService/tspconfig.yaml', and CommitSHA: '88e90ae653598778320aa0a37da27f5ce85979e0' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6783650 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36386 Submitted by: Dapeng.Zhang@microsoft.com

Copilot AI balanced review requested due to automatic review settings September 3, 2026 08:39
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 3, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changelog contains an unresolved generator placeholder instead of release notes for the public API changes.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Regenerates the Web PubSub management SDK from the updated TypeSpec specification and advances the preview package to 3.0.0b2.

Changes:

  • Updates generation metadata and API artifacts.
  • Refreshes generated models, operation classes, and serialization helpers.
  • Adds the new beta release entry, which still needs finalized release notes.
File summaries
File Description
tsp-location.yaml Updates the specification commit.
CHANGELOG.md Adds the 3.0.0b2 release entry.
azure/mgmt/webpubsub/types.py Refreshes generated type definitions.
operations/_patch.py Removes generated whitespace.
operations/_operations.py Updates generated pylint suppressions.
models/_patch.py Removes generated whitespace.
models/_models.py Updates generated model suppressions and formatting.
aio/operations/_patch.py Removes generated whitespace.
aio/operations/_operations.py Updates asynchronous operation suppressions.
aio/_patch.py Removes generated whitespace.
aio/_configuration.py Updates generated pylint configuration.
aio/_client.py Updates asynchronous client lint annotations.
_version.py Bumps the package to 3.0.0b2.
_utils/serialization.py Expands serializer documentation.
_utils/model_base.py Adds string-form boolean deserialization and documentation updates.
_patch.py Removes generated whitespace.
_configuration.py Updates generated pylint configuration.
_client.py Updates synchronous client lint annotations.
apiview-properties.json Refreshes the cross-language API version.
api.metadata.yml Updates APIView generation metadata.
api.md Refreshes the recorded public API surface.
_metadata.json Updates specification and emitter metadata.
Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/webpubsub/azure-mgmt-webpubsub/CHANGELOG.md Outdated
Copilot AI review requested due to automatic review settings September 3, 2026 10:02
@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Sep 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changelog does not disclose the public TypedDict removals shown in the API surface update.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 22/22 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread sdk/webpubsub/azure-mgmt-webpubsub/CHANGELOG.md
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Unverified checks: None.

Review summary

Affected package: sdk/webpubsub/azure-mgmt-webpubsub

Checks completed:

  • API version consistency: _metadata.json apiVersion 2025-12-01-preview unchanged between first (96d9fed) and latest (25b0e5f) revisions.
  • Version consistency: _version.py (3.0.0b2) matches latest CHANGELOG.md entry (3.0.0b2).
  • Preview API/version alignment: preview API version paired with beta SDK version (3.0.0b2), not stable.
  • Changelog date: latest entry dated 2026-09-03, not more than 3 weeks in the future.
  • pyproject.toml stability flags: preview version (b in version) correctly has is_stable = false and classifier Development Status :: 4 - Beta.
  • Client signature: WebPubSubManagementClient.__init__ in _client.py has credential, subscription_id, base_url in the required order; subscription_id present so no_sub is not required.
  • Client name consistency: WebPubSubManagementClient matches across _client.py, README.md, and pyproject.toml title.
  • README code snippets: sample usage matches the actual client constructor signature.

No blocking, warning, or suggestion findings identified for this PR.

@ChenxiJiang333

ChenxiJiang333 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Hi Dapeng Zhang (@ArcturusZhang), sdk targets 2025-12-01-preview has already been released. Are you going to insist on releasing this package with no new changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants