Add support for JUnit 6 in azure-sdk-archetype - #50444
Open
Alan Zimmer (alzimmermsft) wants to merge 4 commits into
Open
Alan Zimmer (alzimmermsft) wants to merge 4 commits into
Alan Zimmer (alzimmermsft) wants to merge 4 commits into
Conversation
Alan Zimmer (alzimmermsft)
requested review from
a team,
Jonathan Giles (JonathanGiles),
Vinay Gera (g2vinay),
Moary Chen (moarychan) and
Xiaolu Dai (saragluna)
as code owners
September 14, 2026 16:28
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Alan Zimmer (alzimmermsft)
September 14, 2026 16:29
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
JUnit 6 dependency metadata is unused and conflicts with the template version, requiring correction before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds JUnit 6 support to azure-sdk-archetype while preserving JUnit 4 and JUnit 5 generation.
Changes:
- Adds JUnit 6 configuration, dependencies, tests, and documentation.
- Updates JUnit 5 dependency metadata and integration coverage.
- Improves cross-platform post-generation output and changelog coverage.
File summaries
| File | Summary |
|---|---|
sdk/tools/azure-sdk-archetype/src/test/resources/projects/verify.groovy |
Verifies generated dependency versions and test reports. |
sdk/tools/azure-sdk-archetype/src/test/resources/projects/junit6/goal.txt |
Runs the JUnit 6 generated-project tests. |
sdk/tools/azure-sdk-archetype/src/test/resources/projects/junit6/archetype.properties |
Defines the JUnit 6 test scenario. |
sdk/tools/azure-sdk-archetype/src/test/resources/projects/junit5-default/goal.txt |
Runs the default JUnit 5 tests. |
sdk/tools/azure-sdk-archetype/src/test/resources/projects/junit5-default/archetype.properties |
Defines the default JUnit 5 scenario. |
sdk/tools/azure-sdk-archetype/src/test/resources/projects/junit4/goal.txt |
Runs the JUnit 4 tests. |
sdk/tools/azure-sdk-archetype/src/test/resources/projects/junit4/archetype.properties |
Defines the JUnit 4 scenario. |
sdk/tools/azure-sdk-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml |
Allows JUnit version 6. |
sdk/tools/azure-sdk-archetype/src/main/resources/META-INF/archetype-post-generate.groovy |
Improves portable status output. |
sdk/tools/azure-sdk-archetype/src/main/resources/archetype-resources/src/test/java/AppTest.java |
Generates Jupiter-compatible tests for JUnit 5 and 6. |
sdk/tools/azure-sdk-archetype/src/main/resources/archetype-resources/pom.xml |
Adds JUnit 6 and Surefire configuration; the JUnit 6 version conflicts with tracked metadata (moderate, 1 vote). |
sdk/tools/azure-sdk-archetype/README.md |
Documents JUnit 6 usage and testing. |
sdk/tools/azure-sdk-archetype/pom.xml |
Configures archetype integration tests. |
sdk/tools/azure-sdk-archetype/CHANGELOG.md |
Records the new support and fixes. |
eng/versioning/external_dependencies.txt |
Registers JUnit 6 metadata, but the alias is unused and its version conflicts with the template (critical, 2 votes). |
Review details
Suppressed comments (1)
sdk/tools/azure-sdk-archetype/src/main/resources/archetype-resources/pom.xml:25
- The JUnit 6 version is inconsistent with the dependency registered for this archetype:
eng/versioning/external_dependencies.txtaddsarchetype_org.junit.jupiter:junit-jupiter;6.0.3, but this template resolves6.1.3. Generated projects therefore use an untracked/different version, and the repository versioning checks cannot update it. Use the tracked version and attach the matching external-dependency marker to this property.
<junit6.version>6.1.3</junit6.version>
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for JUnit 6 as the testing framework in
azure-sdk-archetype. Updates dependency version of JUnit 5 to latest release.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines