Make Azure DevOps pipeline conditions cancellable

eng/common/TestResources/remove-test-resources.yml

@@ -27,7 +27,7 @@ steps:
   - ${{ if eq('true', parameters.UseFederatedAuth) }}:
     - task: AzurePowerShell@5
       displayName: Remove test resources
-      condition: and(eq(variables['CI_HAS_DEPLOYED_RESOURCES'], 'true'), ne(variables['Skip.RemoveTestResources'], 'true'))
+      condition: and(succeededOrFailed(), eq(variables['CI_HAS_DEPLOYED_RESOURCES'], 'true'), ne(variables['Skip.RemoveTestResources'], 'true'))
       continueOnError: true
       env:
         PoolSubnet: $(PoolSubnet)
@@ -71,7 +71,7 @@ steps:
           -Force `
           -Verbose
       displayName: Remove test resources
-      condition: and(eq(variables['CI_HAS_DEPLOYED_RESOURCES'], 'true'), ne(variables['Skip.RemoveTestResources'], 'true'))
+      condition: and(succeededOrFailed(), eq(variables['CI_HAS_DEPLOYED_RESOURCES'], 'true'), ne(variables['Skip.RemoveTestResources'], 'true'))
       continueOnError: true
       env:
         PoolSubnet: $(PoolSubnet)

eng/common/TestResources/setup-environments.yml

@@ -18,7 +18,7 @@
 steps:
   - bash: sudo chown -R runner ~/.Azure
     displayName: (MacOS) Grant access to ~/.Azure
-    condition: contains(variables['OSVmImage'], 'mac')
+    condition: and(succeeded(), contains(variables['OSVmImage'], 'mac'))
 
   - task: Powershell@2
     displayName: Setup Az Modules and Dogfood Environment

eng/common/pipelines/templates/jobs/npm-publish.yml

@@ -16,7 +16,7 @@ parameters:
 jobs:
 - deployment: ${{ parameters.DeploymentName }}
   displayName: 'Publish ${{ parameters.ArtifactName }} to ${{ parameters.Registry }}' 
-  condition: ${{ parameters.CustomCondition }}
+  condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }})
   environment: ${{ parameters.Environment }}
   dependsOn: ${{ parameters.DependsOn }}
   variables:

eng/common/pipelines/templates/stages/archetype-auto-release-prepare.yml

@@ -32,7 +32,7 @@ stages:
   - stage: AutoReleasePrepare
     displayName: Auto-release prepare
     dependsOn: ${{ parameters.DependsOn }}
-    condition: ${{ parameters.Condition }}
+    condition: and(succeededOrFailed(), ${{ parameters.Condition }})
     variables:
       - template: /eng/pipelines/templates/variables/globals.yml
       - template: /eng/pipelines/templates/variables/image.yml

eng/common/pipelines/templates/steps/create-authenticated-npmrc.yml

@@ -31,11 +31,11 @@ steps:
       "registry=${{ parameters.registryUrl }}" | Out-File $npmrcPath
       Write-Host "##vso[task.setvariable variable=resolvedNpmrcPath]$npmrcPath"
     displayName: "Create .npmrc"
-    condition: ${{ parameters.CustomCondition }}
+    condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }})
 
   - task: npmAuthenticate@0
     displayName: Authenticate .npmrc
-    condition: ${{ parameters.CustomCondition }}
+    condition: and(succeededOrFailed(), ${{ parameters.CustomCondition }})
     inputs:
       workingFile: $(resolvedNpmrcPath)
       azureDevOpsServiceConnection: ${{ parameters.ServiceConnection }}

eng/common/pipelines/templates/steps/daily-dev-build-variable.yml

@@ -16,12 +16,12 @@ steps:
       pwsh: true
       workingDirectory: $(Pipeline.Workspace)
     displayName: Dump Package properties
-    condition: ${{ parameters.Condition }}
+    condition: and(succeededOrFailed(), ${{ parameters.Condition }})
 - pwsh: |
     $setDailyDevBuild = "false"
     if (('$(Build.Reason)' -eq 'Schedule') -and ('$(System.TeamProject)' -eq 'internal')) {
       $setDailyDevBuild = "true"
     }
     echo "##vso[task.setvariable variable=SetDevVersion]$setDailyDevBuild"
   displayName: "Setup Versioning Properties"
-  condition: and(${{ parameters.Condition }}, eq(variables['SetDevVersion'], ''))
+  condition: and(succeededOrFailed(), ${{ parameters.Condition }}, eq(variables['SetDevVersion'], ''))

eng/common/pipelines/templates/steps/install-azsdk-cli.yml

@@ -6,7 +6,7 @@ parameters:
 steps:
   - task: Powershell@2
     displayName: 'Install Azure SDK Tools CLI'
-    condition: ${{ parameters.Condition }}
+    condition: and(succeededOrFailed(), ${{ parameters.Condition }})
     inputs:
       targetType: 'inline'
       script: |

eng/common/pipelines/templates/steps/set-default-branch.yml

@@ -14,5 +14,5 @@ steps:
     Write-Host "##vso[task.setvariable variable=${{ parameters.DefaultBranchVariableName }}]$setDefaultBranch"
   displayName: "Setup Default Branch"
   workingDirectory: ${{ parameters.workingDirectory }}
-  condition: ${{ parameters.Condition }}
+  condition: and(succeededOrFailed(), ${{ parameters.Condition }})
   ignoreLASTEXITCODE: true

eng/common/pipelines/templates/steps/verify-changelog.yml

@@ -26,5 +26,5 @@ steps:
       pwsh: true
       workingDirectory: $(Pipeline.Workspace)
     displayName: Verify ChangeLogEntry for ${{ parameters.PackageName }}
-    condition: ${{ parameters.Condition }}
+    condition: and(succeededOrFailed(), ${{ parameters.Condition }})
     continueOnError: false

eng/common/pipelines/templates/steps/verify-changelogs.yml

@@ -17,4 +17,4 @@ steps:
         -ForRelease $${{ parameters.ForRelease }}
       pwsh: true
     displayName: Verify ChangeLogEntries
-    condition: ${{ parameters.Condition }}
+    condition: and(succeededOrFailed(), ${{ parameters.Condition }})

eng/common/pipelines/templates/steps/verify-links.yml

@@ -17,7 +17,7 @@ steps:
       Condition: ${{ parameters.Condition }}
   - task: PowerShell@2
     displayName: Link verification check
-    condition: ${{ parameters.Condition }}
+    condition: and(succeededOrFailed(), ${{ parameters.Condition }})
     inputs:
       pwsh: true
       workingDirectory: '${{ parameters.WorkingDirectory }}/${{ parameters.Directory }}'

eng/common/pipelines/templates/steps/verify-path-length.yml

@@ -7,7 +7,7 @@ parameters:
 steps:
   - task: PythonScript@0
     displayName: Analyze Path Lengths
-    condition: ${{ parameters.Condition }}
+    condition: and(succeededOrFailed(), ${{ parameters.Condition }})
     inputs:
       scriptSource: inline
       script: |

eng/common/pipelines/templates/steps/verify-readme.yml

@@ -22,7 +22,7 @@ parameters:
 steps:
 - task: PowerShell@2
   displayName: "Verify Readmes"
-  condition: ${{ parameters.Condition }}
+  condition: and(succeededOrFailed(), ${{ parameters.Condition }})
   inputs:
     filePath: "eng/common/scripts/Verify-Readme.ps1"
     arguments: >

eng/common/pipelines/templates/steps/verify-readmes.yml

@@ -36,11 +36,11 @@ steps:
     $scanPaths = $paths -join ","
     Write-Host "##vso[task.setvariable variable=ScanPathArgument;]$scanPaths"
   displayName: Populate Scan Paths
-  condition: ${{ parameters.Condition }}
+  condition: and(succeededOrFailed(), ${{ parameters.Condition }})
 
 - task: PowerShell@2
   displayName: "Verify Readmes"
-  condition: ${{ parameters.Condition }}
+  condition: and(succeededOrFailed(), ${{ parameters.Condition }})
   inputs:
     filePath: "eng/common/scripts/Verify-Readme.ps1"
     arguments: >

eng/pipelines/templates/jobs/ci.tests.yml

@@ -110,7 +110,7 @@ jobs:
         - output: pipelineArtifact
           targetPath: '$(Build.ArtifactStagingDirectory)/llm-artifacts'
           artifactName: "LLM Artifacts - $(System.JobName) - $(System.JobAttempt)"
-          condition: eq(variables['uploadLlmArtifacts'], 'true')
+          condition: and(succeeded(), eq(variables['uploadLlmArtifacts'], 'true'))
           sbomEnabled: false
 
     steps:

eng/pipelines/templates/jobs/ci.versions.tests.yml

@@ -32,7 +32,7 @@ parameters:
 
 jobs:
   - job:
-    condition: ne(variables['Skip.Test'], 'true')
+    condition: and(succeeded(), ne(variables['Skip.Test'], 'true'))
 
     variables:
       - template: /eng/pipelines/templates/variables/globals.yml

eng/pipelines/templates/jobs/live.tests.yml

@@ -171,4 +171,3 @@ jobs:
               UseFederatedAuth: ${{ parameters.UseFederatedAuth }}
               ServiceConnection: ${{ parameters.CloudConfig.ServiceConnection }}
               SubscriptionConfigurationFilePaths: ${{ parameters.CloudConfig.SubscriptionConfigurationFilePaths }}
-

eng/pipelines/templates/stages/archetype-java-auto-release-batch.yml

@@ -90,7 +90,7 @@ stages:
       - job: VerifyReleaseVersion
         displayName: Verify auto-release versions
         dependsOn: PrepareAutoReleasePackages
-        condition: ne(variables['Skip.VersionVerification'], 'true')
+        condition: and(succeeded(), ne(variables['Skip.VersionVerification'], 'true'))
         pool:
           name: $(LINUXPOOL)
           image: $(LINUXVMIMAGE)

eng/pipelines/templates/stages/archetype-java-release-batch.yml

@@ -108,7 +108,7 @@ stages:
       jobs:
         - job: VerifyReleaseVersion
           displayName: "Verify release versions"
-          condition: ne(variables['Skip.VersionVerification'], 'true')
+          condition: and(succeeded(), ne(variables['Skip.VersionVerification'], 'true'))
           pool:
             name: $(LINUXPOOL)
             image: $(LINUXVMIMAGE)
@@ -433,7 +433,7 @@ stages:
         - template: /eng/pipelines/templates/variables/image.yml
       jobs:
       - job: PublishPackages
-        condition: or(eq(variables['SetDevVersion'], 'true'), and(eq(variables['Build.Reason'],'Schedule'), eq(variables['System.TeamProject'], 'internal')))
+        condition: and(succeeded(), or(eq(variables['SetDevVersion'], 'true'), and(eq(variables['Build.Reason'],'Schedule'), eq(variables['System.TeamProject'], 'internal'))))
         displayName: Publish package to daily feed
 
         templateContext:

eng/pipelines/templates/stages/archetype-java-release-pom-only.yml

@@ -85,7 +85,7 @@ stages:
         jobs:
           - job: TagRepository
             displayName: "Create release tag"
-            condition: ne(variables['Skip.TagRepository'], 'true')
+            condition: and(succeeded(), ne(variables['Skip.TagRepository'], 'true'))
             pool:
               name: $(WINDOWSPOOL)
               image: $(WINDOWSVMIMAGE)

eng/pipelines/templates/stages/archetype-sdk-client.yml

@@ -101,7 +101,7 @@ extends:
                   displayName: Skip PR validation
 
       - stage: Build
-        condition: not(and(eq(${{ parameters.SkipPrValidation }}, true), eq(variables['Build.Reason'], 'Manual')))
+        condition: and(succeeded(), not(and(eq(${{ parameters.SkipPrValidation }}, true), eq(variables['Build.Reason'], 'Manual'))))
         variables:
           - template: /eng/pipelines/templates/variables/globals.yml
           - template: /eng/pipelines/templates/variables/image.yml
@@ -208,4 +208,3 @@ extends:
               TestPipeline: ${{ parameters.TestPipeline }}
               PublicFeedUrl: ${{ parameters.PublicFeedUrl }}
               PublicPublishEnvironment: ${{ parameters.PublicPublishEnvironment }}
-

eng/pipelines/templates/steps/build-and-test-native.yml

@@ -64,15 +64,15 @@ steps:
   # Generate the pom file with all the modules required for creating an aggregate code coverage report
   - task: PythonScript@0
     displayName: 'Generate pom for aggregate code coverage report'
-    condition: eq(variables['RunAggregateReports'], 'true')
+    condition: and(succeeded(), eq(variables['RunAggregateReports'], 'true'))
     inputs:
       scriptPath: 'eng/scripts/generate_aggregate_pom.py'
       arguments: '--project-list $(ProjectList) --exclude-project-list ${{ parameters.ExcludeProjectList }} --type coverage'
       workingDirectory: '$(System.DefaultWorkingDirectory)'
 
   - task: Maven@4
     displayName: 'Generate aggregate code coverage report'
-    condition: eq(variables['RunAggregateReports'], 'true')
+    condition: and(succeeded(), eq(variables['RunAggregateReports'], 'true'))
     inputs:
       mavenPomFile: aggregate-pom.xml
       options: '$(DefaultOptions)'
@@ -139,7 +139,7 @@ steps:
   # Azure DevOps only seems to respect the last code coverage result published, so only do this for Windows + Java LTS.
   # Code coverage reporting is set up only for Track 2 modules.
   - task: PublishCodeCoverageResults@2
-    condition: eq(variables['RunAggregateReports'], 'true')
+    condition: and(succeeded(), eq(variables['RunAggregateReports'], 'true'))
     inputs:
       summaryFileLocation: target/site/test-coverage/jacoco.xml
       reportDirectory: target/site/test-coverage/

eng/pipelines/templates/steps/build-and-test.yml

@@ -146,7 +146,7 @@ steps:
       scriptPath: 'eng/scripts/generate_aggregate_pom.py'
       arguments: '--project-list $(ProjectList) --exclude-project-list ${{ parameters.ExcludeProjectList }} --type coverage'
       workingDirectory: '$(System.DefaultWorkingDirectory)'
-    condition: eq(variables['RunAggregateReports'], 'true')
+    condition: and(succeeded(), eq(variables['RunAggregateReports'], 'true'))
 
   - task: Maven@4
     displayName: 'Generate aggregate code coverage report'
@@ -158,7 +158,7 @@ steps:
       jdkVersionOption: $(JavaTestVersion)
       jdkArchitectureOption: 'x64'
       goals: jacoco:report-aggregate
-    condition: eq(variables['RunAggregateReports'], 'true')
+    condition: and(succeeded(), eq(variables['RunAggregateReports'], 'true'))
 
   - task: Maven@4
     displayName: 'Build for From Source run'
@@ -285,4 +285,4 @@ steps:
       summaryFileLocation: target/site/test-coverage/jacoco.xml
       reportDirectory: target/site/test-coverage/
       failIfCoverageEmpty: false
-    condition: eq(variables['RunAggregateReports'], 'true')
+    condition: and(succeeded(), eq(variables['RunAggregateReports'], 'true'))

eng/pipelines/templates/steps/install-latest-jdk.yml

@@ -11,7 +11,7 @@ steps:
       key: 'jdk | "1.${{ parameters.LatestJdkFeatureVersion }}" | "$(CacheSalt)" | "$(Agent.OS)"'
       path: $(Agent.BuildDirectory)/jdk-${{ parameters.LatestJdkFeatureVersion }}
     displayName: 'Cache Latest JDK'
-    condition: eq(variables['IsLatestNonLtsJdk'], 'true')
+    condition: and(succeeded(), eq(variables['IsLatestNonLtsJdk'], 'true'))
 
   - task: PowerShell@2
     displayName: 'Install Latest JDK'
@@ -21,7 +21,7 @@ steps:
         -JdkFeatureVersion ${{ parameters.LatestJdkFeatureVersion }}
       workingDirectory: $(Agent.BuildDirectory)
       filePath: eng/scripts/Install-Latest-JDK.ps1
-    condition: eq(variables['IsLatestNonLtsJdk'], 'true')
+    condition: and(succeeded(), eq(variables['IsLatestNonLtsJdk'], 'true'))
 
   - pwsh: |
       Write-Host "Java 8 JDK: $Env:JAVA_HOME_8_X64"
@@ -30,7 +30,7 @@ steps:
       Write-Host "Java 21 JDK: $Env:JAVA_HOME_21_X64"
       Write-Host "Latest JDK: $Env:JAVA_HOME_${{ parameters.LatestJdkFeatureVersion }}_X64"
     displayName: 'Verify Latest JDK Install'
-    condition: eq(variables['IsLatestNonLtsJdk'], 'true')
+    condition: and(succeeded(), eq(variables['IsLatestNonLtsJdk'], 'true'))
 
   - task: PowerShell@2
     displayName: 'Install JDK 8 on macOS'
@@ -40,4 +40,4 @@ steps:
         -JdkFeatureVersion 8
       workingDirectory: $(Agent.BuildDirectory)
       filePath: eng/scripts/Install-Latest-JDK.ps1
-    condition: eq(variables['Agent.OS'], 'Darwin')
+    condition: and(succeeded(), eq(variables['Agent.OS'], 'Darwin'))

sdk/spring/pipeline/compatibility-tests-job.yml

@@ -68,7 +68,7 @@ jobs:
       - template: /eng/pipelines/templates/steps/maven-authenticate.yml
       - task: Maven@4
         displayName: 'Install Unreleased Dependencies'
-        condition: ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], '')
+        condition: and(succeeded(), ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], ''))
         inputs:
           mavenPomFile: sdk/spring/pipeline/ClientFromSourcePom.xml
           goals: 'install'
@@ -81,25 +81,25 @@ jobs:
       - bash: |
           echo "##vso[task.setVariable variable=SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_CLOUD_VERSION]$(python ./sdk/spring/scripts/compatibility_get_spring_cloud_version.py -b $(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION))"
         displayName: 'Set supported Spring version to environment variables'
-        condition: ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], '')
+        condition: and(succeeded(), ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], ''))
       - bash: |
           echo "$(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION):"
           echo "https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/$(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION)/spring-boot-dependencies-$(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION).pom"
           echo "$(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_CLOUD_VERSION):"
           echo "https://repo1.maven.org/maven2/org/springframework/cloud/spring-cloud-dependencies/$(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_CLOUD_VERSION)/spring-cloud-dependencies-$(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_CLOUD_VERSION).pom"
         displayName: 'Log Spring version and Maven pom path'
-        condition: ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], '')
+        condition: and(succeeded(), ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], ''))
       - script: |
           python ./sdk/spring/scripts/compatibility_insert_dependencymanagement.py -b $(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION) -c $(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_CLOUD_VERSION)
         displayName: 'Insert Spring dependency managements'
-        condition: ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], '')
+        condition: and(succeeded(), ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], ''))
       - script: |
             python ./sdk/spring/scripts/compatibility_delete_version.py -b $(SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION)
         displayName: 'Remove unused dependency versions'
-        condition: ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], '')
+        condition: and(succeeded(), ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], ''))
       - task: Maven@4
         displayName: 'Run tests'
-        condition: ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], '')
+        condition: and(succeeded(), ne(variables['SPRING_CLOUD_AZURE_TEST_SUPPORTED_SPRING_BOOT_VERSION'], ''))
         inputs:
           options: '$(DefaultOptions) -ntp -T ${{parameters.BuildParallelization}} ${{parameters.SkipOptions}} -Dcompiler.failondeprecatedstatus=- --fail-at-end'
           mavenPomFile: sdk/spring/pom.xml