Skip to content

Upgrade Netty and Reactor versions #50418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Alan Zimmer (alzimmermsft) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade Netty and Reactor versions #50418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/perf-test-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<!-- Special allowance for performance libraries as they aren't shipped. -->
<include>com.beust:jcommander:[1.82]</include> <!-- {x-include-update;com.beust:jcommander;external_dependency} -->
<include>io.vertx:vertx-codegen:[4.5.32]</include> <!-- {x-include-update;io.vertx:vertx-codegen;external_dependency} -->
<include>io.projectreactor:reactor-core:[3.7.19]</include> <!-- {x-include-update;io.projectreactor:reactor-core;external_dependency} -->
<include>io.projectreactor:reactor-core:[3.8.7]</include> <!-- {x-include-update;io.projectreactor:reactor-core;external_dependency} -->
</includes>
</bannedDependencies>
</rules>
Expand Down
34 changes: 17 additions & 17 deletions eng/versioning/external_dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,22 +44,22 @@ commons-net:commons-net;3.9.0
io.cloudevents:cloudevents-api;2.2.0
io.cloudevents:cloudevents-core;2.2.0
io.fabric8:kubernetes-client;6.12.1
io.netty:netty-buffer;4.1.137.Final
io.netty:netty-common;4.1.137.Final
io.netty:netty-codec;4.1.137.Final
io.netty:netty-codec-http;4.1.137.Final
io.netty:netty-codec-http2;4.1.137.Final
io.netty:netty-handler;4.1.137.Final
io.netty:netty-handler-proxy;4.1.137.Final
io.netty:netty-resolver;4.1.137.Final
io.netty:netty-resolver-dns;4.1.137.Final
io.netty:netty-buffer;4.2.17.Final
io.netty:netty-common;4.2.17.Final
io.netty:netty-codec-base;4.2.17.Final
io.netty:netty-codec-http;4.2.17.Final
io.netty:netty-codec-http2;4.2.17.Final
io.netty:netty-handler;4.2.17.Final
io.netty:netty-handler-proxy;4.2.17.Final
io.netty:netty-resolver;4.2.17.Final
io.netty:netty-resolver-dns;4.2.17.Final
io.netty:netty-tcnative-boringssl-static;2.0.81.Final
io.netty:netty-transport;4.1.137.Final
io.netty:netty-transport-native-epoll;4.1.137.Final
io.netty:netty-transport-native-unix-common;4.1.137.Final
io.netty:netty-transport-native-kqueue;4.1.137.Final
io.projectreactor.netty:reactor-netty-http;1.2.18
io.projectreactor:reactor-core;3.7.19
io.netty:netty-transport;4.2.17.Final
io.netty:netty-transport-native-epoll;4.2.17.Final
io.netty:netty-transport-native-unix-common;4.2.17.Final
io.netty:netty-transport-native-kqueue;4.2.17.Final
io.projectreactor.netty:reactor-netty-http;1.3.7
io.projectreactor:reactor-core;3.8.7
io.vertx:vertx-codegen;4.5.32
io.vertx:vertx-core;4.5.32
javax.websocket:javax.websocket-api;1.1
Expand Down Expand Up @@ -125,7 +125,7 @@ io.opentelemetry:opentelemetry-bom;1.58.0
io.opentelemetry.instrumentation:opentelemetry-runtime-telemetry-java8;2.24.0-alpha
io.opentelemetry.instrumentation:opentelemetry-spring-boot-starter;2.24.0
io.opentelemetry.instrumentation:opentelemetry-logback-appender-1.0;2.24.0-alpha
io.projectreactor:reactor-test;3.7.19
io.projectreactor:reactor-test;3.8.7
io.github.hakky54:logcaptor;2.9.3
com.squareup.okio:okio;3.18.1
com.squareup.okio:okio-jvm;3.18.1
Expand Down Expand Up @@ -207,7 +207,7 @@ org.revapi:revapi-reporter-json;0.5.1
org.revapi:revapi-maven-plugin;0.15.1

# External Dependency Exceptions
# This section is for external dependencies whose versions were different than
# This section is for external dependencies whose versions were different from
# what was defined in the parent pom.
# Format;
# <some unique identifier, area name preferred>_groupId:artifactId;dependency-version
Expand Down
8 changes: 4 additions & 4 deletions eng/versioning/supported_external_dependency_versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,10 @@
],
"reactor_2025":
[
{ "io.projectreactor.netty:reactor-netty": "1.3.0-M2" },
{ "io.projectreactor.netty:reactor-netty-http": "1.3.0-M2" },
{ "io.projectreactor:reactor-core": "3.8.0-M2" },
{ "io.projectreactor:reactor-test": "3.8.0-M2" }
{ "io.projectreactor.netty:reactor-netty": "1.3.0" },
{ "io.projectreactor.netty:reactor-netty-http": "1.3.0" },
{ "io.projectreactor:reactor-core": "3.8.0" },
{ "io.projectreactor:reactor-test": "3.8.0" }
],
"reactor_2024":
[
Expand Down
4 changes: 4 additions & 0 deletions sdk/clientcore/http-netty4/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,7 @@
### Bugs Fixed

### Other Changes

- Upgraded Netty to `4.2.17.Final`, using I/O handler factories for event loops while preserving pooled buffer allocation
unless `io.netty.allocator.type` is explicitly configured.
- Preserved HTTP/2 response decompression with Netty's separate compression module when using Java modules.
62 changes: 24 additions & 38 deletions sdk/clientcore/http-netty4/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
io.clientcore.core.implementation*,io.clientcore.core.models,io.clientcore.core.util,io.clientcore.core.util*
</javadoc.excludePackageNames>

<netty.version>4.1.137.Final</netty.version> <!-- {x-version-update;io.netty:netty-common;external_dependency} -->
<netty.version>4.2.17.Final</netty.version> <!-- {x-version-update;io.netty:netty-common;external_dependency} -->
</properties>

<dependencies>
Expand All @@ -69,52 +69,52 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-buffer</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-buffer;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-buffer;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-codec</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-codec;external_dependency} -->
<artifactId>netty-codec-base</artifactId>
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-codec-base;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-codec-http;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-codec-http;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http2</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-codec-http2;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-codec-http2;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-common</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-common;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-common;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-handler;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-handler;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler-proxy</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-handler-proxy;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-handler-proxy;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-resolver</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-resolver;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-resolver;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-resolver-dns</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-resolver-dns;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-resolver-dns;external_dependency} -->
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-transport;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-transport;external_dependency} -->
</dependency>

<!-- Test dependencies on core, because we want to run tests inherited from this module using Netty -->
Expand All @@ -126,32 +126,18 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-unix-common</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-transport-native-unix-common;external_dependency} -->
<classifier>linux-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-transport-native-epoll;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-transport-native-epoll;external_dependency} -->
<classifier>linux-x86_64</classifier>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-unix-common</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-transport-native-unix-common;external_dependency} -->
<classifier>osx-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-kqueue</artifactId>
<version>4.1.137.Final</version> <!-- {x-version-update;io.netty:netty-transport-native-kqueue;external_dependency} -->
<version>4.2.17.Final</version> <!-- {x-version-update;io.netty:netty-transport-native-kqueue;external_dependency} -->
<classifier>osx-x86_64</classifier>
<scope>test</scope>
</dependency>
Expand Down Expand Up @@ -223,16 +209,16 @@
<rules>
<bannedDependencies>
<includes>
<include>io.netty:netty-buffer:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-buffer;external_dependency} -->
<include>io.netty:netty-codec:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-codec;external_dependency} -->
<include>io.netty:netty-codec-http:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-codec-http;external_dependency} -->
<include>io.netty:netty-codec-http2:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-codec-http2;external_dependency} -->
<include>io.netty:netty-common:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-common;external_dependency} -->
<include>io.netty:netty-handler:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-handler;external_dependency} -->
<include>io.netty:netty-handler-proxy:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-handler-proxy;external_dependency} -->
<include>io.netty:netty-resolver:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-resolver;external_dependency} -->
<include>io.netty:netty-resolver-dns:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-resolver-dns;external_dependency} -->
<include>io.netty:netty-transport:[4.1.137.Final]</include> <!-- {x-include-update;io.netty:netty-transport;external_dependency} -->
<include>io.netty:netty-buffer:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-buffer;external_dependency} -->
<include>io.netty:netty-codec-base:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-codec-base;external_dependency} -->
<include>io.netty:netty-codec-http:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-codec-http;external_dependency} -->
<include>io.netty:netty-codec-http2:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-codec-http2;external_dependency} -->
<include>io.netty:netty-common:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-common;external_dependency} -->
<include>io.netty:netty-handler:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-handler;external_dependency} -->
<include>io.netty:netty-handler-proxy:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-handler-proxy;external_dependency} -->
<include>io.netty:netty-resolver:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-resolver;external_dependency} -->
<include>io.netty:netty-resolver-dns:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-resolver-dns;external_dependency} -->
<include>io.netty:netty-transport:[4.2.17.Final]</include> <!-- {x-include-update;io.netty:netty-transport;external_dependency} -->
</includes>
</bannedDependencies>
</rules>
Expand Down
Loading
Loading