Latest spec#49344
Open
jpalvarezl wants to merge 3 commits into
Open
Conversation
jpalvarezl
requested review from
a team,
dargilco,
glecaros,
kaylieee and
trrwilson
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeSpec spec pin for azure-ai-projects and azure-ai-agents to a newer azure-rest-api-specs commit and refreshes generated SDK surface area accordingly (model/type changes plus regenerated metadata).
Changes:
- Bump both packages’
tsp-location.yaml.hidespec commit to6aa89cf5b93d34e6eea85f12b95cd370ba9d58b1. - Regenerate
azure-ai-projectsSkills APIs to useSkillDetails(replacingSkill) and update the Projects metadata hash. - Regenerate Agents optimization-candidate listing APIs to use
PagedIterable/PagedFluxpatterns and removeOptimizationCandidatePagedResult, updating the Agents metadata hash.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-projects/tsp-location.yaml.hide | Update spec commit pin for Projects. |
| sdk/ai/azure-ai-projects/src/main/resources/META-INF/azure-ai-projects_metadata.json | Update generation metadata/version hash and symbol mappings. |
| sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/SkillsClient.java | Switch Skills sync client return types from Skill to SkillDetails. |
| sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/SkillsAsyncClient.java | Switch Skills async client return types from Skill to SkillDetails. |
| sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/models/SkillDetails.java | Generated model now represents the skill resource as SkillDetails (renamed from Skill). |
| sdk/ai/azure-ai-agents/tsp-location.yaml.hide | Update spec commit pin for Agents. |
| sdk/ai/azure-ai-agents/src/main/resources/META-INF/azure-ai-agents_metadata.json | Update generation metadata/version hash and symbol mappings. |
| sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/models/OptimizationCandidatePagedResult.java | Remove generated wrapper model for optimization candidate list results. |
| sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/implementation/AgentsImpl.java | Adjust generated optimization-candidate listing plumbing and paging wrappers. |
| sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/AgentsClient.java | Replace OptimizationCandidatePagedResult with PagedIterable<OptimizationCandidate> convenience APIs. |
| sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/AgentsAsyncClient.java | Replace OptimizationCandidatePagedResult with PagedFlux<OptimizationCandidate> convenience APIs. |
Comments suppressed due to low confidence (1)
sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/models/SkillDetails.java:23
Skillhas been renamed toSkillDetailsand all public client methods now returnSkillDetails, but there are still in-repo references tocom.azure.ai.projects.models.Skill(for examplesdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/SamplesTests.javaand severalsrc/samplesclasses). WithSkillno longer present incom.azure.ai.projects.models, the module won’t compile until those references are updated or a compatibility type is provided.
Comment on lines
7091
to
+7098
| * <p><strong>Response Body Schema</strong></p> | ||
| * | ||
| * <pre> | ||
| * {@code | ||
| * { | ||
| * data (Required): [ | ||
| * (Required){ | ||
| * candidate_id: String (Optional) | ||
| * name: String (Required) | ||
| * config (Required): { | ||
| * agent_name: String (Optional) | ||
| * agent_version: String (Optional) | ||
| * model: String (Optional) | ||
| * system_prompt: String (Optional) | ||
| * skills (Optional): [ | ||
| * (Optional){ | ||
| * String: BinaryData (Required) | ||
| * } | ||
| * ] | ||
| * tools (Optional): [ | ||
| * (Optional){ | ||
| * String: BinaryData (Required) | ||
| * } | ||
| * ] | ||
| * candidate_id: String (Optional) | ||
| * name: String (Required) | ||
| * config (Required): { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a breaking change to the way optimization candidates are listed in the Azure AI Agents SDK. The main update is that the
listOptimizationCandidatesmethods on bothAgentsClientandAgentsAsyncClientnow return paginated results ofOptimizationCandidateobjects instead of the oldOptimizationCandidatePagedResultmodel. Additionally, protocol-style overloads have been added for more flexible, raw page access. Documentation and method signatures have been updated accordingly.Breaking Changes
Optimization Candidate Listing:
listOptimizationCandidatesmethods onAgentsClientandAgentsAsyncClientnow return paginated results (PagedIterable<OptimizationCandidate>/PagedFlux<OptimizationCandidate>) instead ofOptimizationCandidatePagedResultorMono<OptimizationCandidatePagedResult>. TheOptimizationCandidatePagedResultmodel has been removed, and related protocol methods have been updated to reflect this change. [1] [2] [3] [4] [5]Features Added
Protocol-Style Overloads:
listOptimizationCandidates(String, RequestOptions)overloads to bothAgentsClientandAgentsAsyncClient. These allow listing raw optimization candidate pages asBinaryDatafor advanced scenarios. [1] [2]Code and Documentation Updates
Imports and Documentation:
OptimizationCandidateinstead of the removedOptimizationCandidatePagedResult. [1] [2]These changes modernize the SDK's API for listing optimization candidates, making it more consistent with Azure SDK guidelines and improving usability for paginated data scenarios.