-
Notifications
You must be signed in to change notification settings - Fork 150
Sync eng/common directory with azure-sdk-tools for PR 13750 #6934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR syncs the eng/common infrastructure with updates from azure-sdk-tools PR 13750, switching release-plan completion handling to use the azsdk CLI and wiring in a reusable installer template.
Changes:
- Update
Mark-ReleasePlanCompletion.ps1to call theazsdkCLI to mark release status, removing direct DevOps work item helper usage and adding validation for the CLI path. - Extend the
mark-release-completionpipeline template to install the azsdk CLI via a newinstall-azsdk-cli.ymlstep and pass its path into the script. - Introduce
install-azsdk-cli.yml, a shared template that installs the Azure SDK tools CLI using theazure-sdk-mcp.ps1helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/scripts/Mark-ReleasePlanCompletion.ps1 | Switches release-plan status updates to use the azsdk CLI and adds parameterization/validation for the CLI path. |
| eng/common/pipelines/templates/steps/mark-release-completion.yml | Ensures the azsdk CLI is installed before running the release completion script and passes the CLI path into it. |
| eng/common/pipelines/templates/steps/install-azsdk-cli.yml | Provides a reusable pipeline step to install the azsdk CLI via the MCP installer script. |
eng/common/pipelines/templates/steps/mark-release-completion.yml
Outdated
Show resolved
Hide resolved
ac60d35 to
97ec799
Compare
97ec799 to
d01ddcb
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
d01ddcb to
9575335
Compare
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13750 See eng/common workflow