[Az.SignalR] Migrate Autorest Generation v3 -> v4#29006
Closed
JiaSeng-v wants to merge 10 commits into
Closed
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
wyunchi-ms
reviewed
Dec 24, 2025
Contributor
wyunchi-ms
left a comment
wyunchi-ms
left a comment
There was a problem hiding this comment.
Please update the ChangeLog.md
| Update a custom domain. | ||
|
|
||
| ### Example 2: {{ Add title here }} | ||
| ```powershell |
wyunchi-ms
previously approved these changes
Dec 25, 2025
Contributor
|
/azp run |
Contributor
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
|
Please resolve the conflicts |
JiaSeng-v
force-pushed
the
jiaseng/main/SignalR-v4
branch
from
2f53608 to
8da104a
Compare
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
wyunchi-ms
previously approved these changes
Dec 31, 2025
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Az.SignalR module from AutoRest generation v3 to v4, which is a significant infrastructure update that introduces breaking changes to cmdlet signatures and parameter types.
Key changes:
- Updated cmdlet parameter signatures (e.g.,
-IdentityType→-EnableSystemAssignedIdentity) - Changed property types from enum types to strings for better flexibility
- Added new cmdlets:
Update-AzWebPubSubHubandUpdate-AzWebPubSubCustomDomain - Updated help documentation, examples, and test files to match new signatures
- Added breaking change exceptions to document expected API changes
Reviewed changes
Copilot reviewed 123 out of 128 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/SignalR/SignalR/ChangeLog.md |
Documents breaking changes with link to migration guide |
tools/StaticAnalysis/Exceptions/Az.SignalR/BreakingChangeIssues.csv |
Documents 76 expected breaking changes from type conversions |
src/SignalR/SignalR/help/*.md |
Updated help documentation for new cmdlet signatures and removed obsolete parameters |
src/SignalR/SignalR.Autorest/test/*.ps1 |
Updated test files to use new parameter names |
src/SignalR/SignalR.Autorest/examples/*.md |
Updated examples to reflect new cmdlet syntax |
src/SignalR/SignalR.Autorest/test/*.json |
Updated test recording files with new test data |
src/SignalR/SignalR/Az.SignalR.psd1 |
Updated module manifest with new cmdlet exports |
src/SignalR/SignalR.sln |
Updated solution file structure |
| mydomain wps.manual-test.dev.signalr.azure.com Succeeded | ||
| ``` | ||
|
|
||
| Update a custom domian. |
There was a problem hiding this comment.
Spelling error in the description. "domian" should be "domain".
| mydomain wps.manual-test.dev.signalr.azure.com Succeeded | ||
| ``` | ||
|
|
||
| Update a custom domian. No newline at end of file |
There was a problem hiding this comment.
Spelling error in the description. "domian" should be "domain".
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
Contributor
|
Commenter does not have sufficient privileges for PR 29006 in repo Azure/azure-powershell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.