Skip to content

fix test failing due to concurrent azcli token invocation #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ag-ramachandran merged 2 commits into from
Feb 24, 2026
Merged

fix test failing due to concurrent azcli token invocation #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
348a5c5
added CachingTokenCredential for concurrent azcli token handling
tanmaya-panda1 Feb 19, 2026
9a5f82b
simplified token generation and access
tanmaya-panda1 Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ingest-v2/src/test/java/com/microsoft/azure/kusto/ingest/v2/CachingTokenCredential.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
package com.microsoft.azure.kusto.ingest.v2;

import com.azure.core.credential.AccessToken;
import com.azure.core.credential.TokenCredential;
import com.azure.core.credential.TokenRequestContext;
import com.azure.identity.AzureCliCredentialBuilder;
import reactor.core.publisher.Mono;

/**
* Test-only credential: calls {@code az} once at class load, reuses the token forever.
*/
public class CachingTokenCredential implements TokenCredential {

private static final AccessToken TOKEN;

static {
// Runs once on main thread before any reactor threads — .block() is safe here.
TOKEN = new AzureCliCredentialBuilder().build()
.getToken(new TokenRequestContext().addScopes("https://kusto.kusto.windows.net/.default"))
.block();
}

public static final TokenCredential INSTANCE = new CachingTokenCredential();

@Override
public Mono<AccessToken> getToken(TokenRequestContext request) {
return Mono.just(TOKEN);
}
}
9 changes: 5 additions & 4 deletions ingest-v2/src/test/java/com/microsoft/azure/kusto/ingest/v2/IngestV2JavaTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
package com.microsoft.azure.kusto.ingest.v2;

import com.azure.core.credential.TokenCredential;
import com.azure.identity.AzureCliCredentialBuilder;
import com.microsoft.azure.kusto.data.Client;
import com.microsoft.azure.kusto.data.ClientFactory;
import com.microsoft.azure.kusto.data.KustoResultSetTable;
Expand Down Expand Up @@ -40,7 +39,8 @@ public abstract class IngestV2JavaTestBase {

public IngestV2JavaTestBase(Class<?> testClass) {
this.logger = LoggerFactory.getLogger(testClass);
this.tokenProvider = new AzureCliCredentialBuilder().build();
// Reuse the shared CachingTokenCredential singleton to prevent multiple concurrent requests to fetch token from azcli
this.tokenProvider = CachingTokenCredential.INSTANCE;
Copy link
Contributor

@ag-ramachandran ag-ramachandran Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This token provider here can be AzureCliTokenProvider perhaps , initialized once


// Get configuration from environment variables
this.database = System.getenv("TEST_DATABASE") != null
Expand Down Expand Up @@ -116,9 +116,10 @@ public void createTables() throws Exception {
}
mappingBuilder.append("\n]```");

// Create admin client
// Create admin client using the shared CachingTokenCredential to prevent
// concurrent az subprocess invocations from parallel test threads
adminClusterClient = ClientFactory.createClient(
ConnectionStringBuilder.createWithAzureCli(engineEndpoint)
ConnectionStringBuilder.createWithTokenCredential(engineEndpoint, tokenProvider)
);

// Execute table creation and mapping
Expand Down
13 changes: 8 additions & 5 deletions ingest-v2/src/test/kotlin/com/microsoft/azure/kusto/ingest/v2/IngestV2TestBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
package com.microsoft.azure.kusto.ingest.v2

import com.azure.core.credential.TokenCredential
import com.azure.identity.AzureCliCredentialBuilder
import com.microsoft.azure.kusto.data.Client
import com.microsoft.azure.kusto.data.ClientFactory
import com.microsoft.azure.kusto.data.auth.ConnectionStringBuilder
Expand All @@ -21,8 +20,11 @@ import kotlin.test.assertTrue

abstract class IngestV2TestBase(testClass: Class<*>) {
protected val logger: Logger = LoggerFactory.getLogger(testClass)
protected val tokenProvider: TokenCredential =
AzureCliCredentialBuilder().build()

// Shared across all test class instances via CachingTokenCredential singleton.
// Ensures az account get-access-token is invoked only once per scope.
protected val tokenProvider: TokenCredential = CachingTokenCredential.INSTANCE

protected val database = System.getenv("TEST_DATABASE") ?: "e2e"
protected val dmEndpoint: String =
System.getenv("DM_CONNECTION_STRING")
Expand Down Expand Up @@ -75,8 +77,9 @@ abstract class IngestV2TestBase(testClass: Class<*>) {
.trimIndent()
adminClusterClient =
ClientFactory.createClient(
ConnectionStringBuilder.createWithAzureCli(
ConnectionStringBuilder.createWithTokenCredential(
engineEndpoint,
tokenProvider,
),
)
adminClusterClient.executeMgmt(database, createTableScript)
Expand Down Expand Up @@ -157,4 +160,4 @@ abstract class IngestV2TestBase(testClass: Class<*>) {
)
}
}
}
}
Loading