{Compute} az vm/vmss list-versions/show: Support extension image release metadata - #34018
Open
William (william051200) wants to merge 7 commits into
Open
{Compute} az vm/vmss list-versions/show: Support extension image release metadata#34018William (william051200) wants to merge 7 commits into
az vm/vmss list-versions/show: Support extension image release metadata#34018William (william051200) wants to merge 7 commits into
Conversation
microsoft-github-policy-service
Bot
requested review from
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 2, 2026 02:49
microsoft-github-policy-service
Bot
added
Compute
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The newly added live-only test has brittle assertions and direct indexing that can fail on valid-but-empty/null service responses, causing false failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the AAZ-generated VM/VMSS extension image list-versions and show commands to use the 2026-04-01 Compute RP API version and surface the newly added extension image release/execution metadata (including support for $expand=properties on list-versions), along with a new live-only scenario test.
Changes:
- Bump API version to
2026-04-01for VM/VMSS extension imagelist-versionsandshow. - Add
--expand propertiestolist-versionsand pass it through as$expand=properties. - Extend response schemas to include release metadata fields and extension feature metadata; add a new live-only test covering the new fields.
File summaries
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Adds a live-only test validating the new release/feature metadata surface area. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/extension/image/_list_versions.py | Updates to 2026-04-01, adds --expand, and extends list response schema for new metadata fields. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/extension/image/_show.py | Updates to 2026-04-01 and extends show response schema for new metadata fields. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/extension/image/_list_versions.py | Updates to 2026-04-01, adds --expand, and extends list response schema for new metadata fields. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/extension/image/_show.py | Updates to 2026-04-01 and extends show response schema for new metadata fields. |
Review details
Suppressed comments (1)
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py:2596
- The test indexes
image['extensionFeatureMetadata']['extensionFeatureTags']directly and then asserts the list is non-empty and that each tag'skey/valueare truthy. If the RP returnsextensionFeatureMetadataas missing/nullor returns an emptyextensionFeatureTagsarray (still a valid shape), this will raise or fail the test even though the response includes the required property.
feature_tags = image['extensionFeatureMetadata']['extensionFeatureTags']
self.assertTrue(feature_tags)
self.assertTrue(all(tag.get('key') and tag.get('value') for tag in feature_tags))
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2591
to
+2593
| for field in ('releaseNotes', 'releaseCategory', 'urgencyLevel', 'runProfile'): | ||
| self.assertTrue(image.get(field)) | ||
|
|
Collaborator
|
Compute |
…1 aaz for vm extension image list-version & show
William (william051200)
force-pushed
the
extension-image
branch
from
September 3, 2026 04:50
7495fa4 to
d745e30
Compare
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
Related command
az vm list-versionsaz vm showaz vmss list-versionsaz vmss showDescription
Resolve #33896
aaz Azure/aaz#1078
Testing Guide
I have added test case in
azure-cli\src\azure-cli\azure\cli\command_modules\vm\tests\latest\test_vm_commands.py:test_vm_vmss_extension_imageBut not able to run due to 2026-04-01 is not ready in the resource provider yet
History Notes
[Compute]
az vm/vmss list-versions: Add new parameter--expandto support extension image release metadataThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.