[Compute-fleet] Commands for Launch mode public preview#33566
Open
sabanermsft wants to merge 7 commits into
Open
[Compute-fleet] Commands for Launch mode public preview#33566sabanermsft wants to merge 7 commits into
sabanermsft wants to merge 7 commits into
Conversation
sabanermsft
requested review from
DanielMicrosoft,
bebound and
yonzhan
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds/updates Azure CLI AAZ-generated compute-fleet commands to align with the 2026-04-01-preview API surface, including new identity subcommands and a new list-vms command.
Changes:
- Introduces
compute-fleet identitysubcommands (show,remove,wait) with generated schemas/operations. - Adds
compute-fleet list-vmsand updates multiple existing commands/examples tocompute-fleetnaming. - Bumps API versions across compute-fleet commands to
2026-04-01-previewand incorporates new Fleet properties (e.g.,capacityType,mode,vmNamePrefix,zoneAllocationPolicy).
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/identity/_wait.py | New identity wait command wiring GET + schema for Fleet/identity. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/identity/_show.py | New identity show command selecting identity subresource from Fleet GET. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/identity/_remove.py | New identity remove command performing Fleet GET + identity JSON update + Fleet PUT (LRO). |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/identity/init.py | Exports identity command group and commands. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/identity/__cmd_group.py | Registers compute-fleet identity command group. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_wait.py | Updates API version and Fleet schema (new properties + dict typing changes). |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_update.py | Updates API version, adds new properties/args, and adjusts dict/prompt handling. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_show.py | Updates examples and API version; extends Fleet read schema. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_list_vmss.py | Updates examples and API version for VMSS listing. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_list_vms.py | New command to list VMs under a Launch mode Fleet with pagination. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_list.py | Updates examples/API version; extends Fleet list schemas. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_delete.py | Updates examples and API version for delete. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/_create.py | Updates API version, adds new properties/args, and adjusts dict/prompt handling. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/init.py | Exports new list-vms command. |
| src/azure-cli/azure/cli/command_modules/computefleet/aaz/latest/compute_fleet/__cmd_group.py | Removes preview flag and trims command group docstring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+324
to
+331
| typ=AAZIdentityObjectType | ||
| ) | ||
| _builder.set_prop("userAssigned", AAZListType, ".mi_user_assigned", typ_kwargs={"flags": {"action": "remove"}}) | ||
| _builder.set_prop("systemAssigned", AAZStrType, ".mi_system_assigned", typ_kwargs={"flags": {"action": "remove"}}) | ||
|
|
||
| user_assigned = _builder.get(".userAssigned") | ||
| if user_assigned is not None: | ||
| user_assigned.set_elements(AAZStrType, ".") |
Comment on lines
14
to
16
| @register_command_group( | ||
| "compute-fleet", | ||
| is_preview=True, | ||
| ) |
Collaborator
|
Compute-fleet |
Contributor
|
please fix the CI issues |
Contributor
|
could you please add some tests for the newly added commands? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
Executed commands locally
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.