[MySQL] Fix #32217: az mysql flexible-server restore: Fix --no-wait flag
#32744
+2,653
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the --no-wait flag for the az mysql flexible-server restore command (and also updates az mysql flexible-server geo-restore). Previously, the --no-wait flag was not honored due to the control flow of the restore/georestore functions. The changes restructure the code to properly support asynchronous operations using callbacks when --no-wait is specified.
Changes:
- Added test coverage for restore with
--no-waitflag - Refactored
flexible_server_restoreto support--no-waitusing callbacks - Attempted to apply the same fix to
flexible_server_georestore(but with critical bugs)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/mysql/tests/latest/test_mysql_scenario.py | Adds new test test_mysql_flexible_server_restore_no_wait_mgmt to validate --no-wait flag behavior |
| src/azure-cli/azure/cli/command_modules/mysql/custom.py | Refactors flexible_server_restore and flexible_server_georestore to properly handle --no-wait flag with callbacks, but georestore implementation has critical bugs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a0x1ab
changed the title
az mysql flexible-server restore: Fix --no-wait flagaz mysql flexible-server restore: Fix --no-wait flag
a0x1ab
changed the title
az mysql flexible-server restore: Fix --no-wait flagaz mysql flexible-server restore: Fix --no-wait flag
calvinhzy
changed the title
az mysql flexible-server restore: Fix --no-wait flagaz mysql flexible-server restore: Fix --no-wait flag
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
calvinhzy
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server restoreDescription
--no-waitflag was not honoured correctly due to the flow of the function process--no-waitflagTesting Guide
az mysql flexible-server restore -g {} --name {} --source-server {} --no-waitHistory Notes
[MySQL] Fix #32217:
az mysql flexible-server restore: Fix--no-waitflagThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.