{Containerapp} Fix Credential Scanner failure#32705
Merged
DanielMicrosoft merged 1 commit intoAzure:devfrom Jan 27, 2026
Merged
{Containerapp} Fix Credential Scanner failure#32705DanielMicrosoft merged 1 commit intoAzure:devfrom
DanielMicrosoft merged 1 commit intoAzure:devfrom
Conversation
DanielMicrosoft
requested review from
Greedygre,
Juliehzl,
howang-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto and
vturecek
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a Container Apps end-to-end test recording to remove a real Log Analytics workspace shared key, resolving credential scanning failures.
Changes:
- Replaces the recorded Log Analytics
sharedKeyvalue with a non-secret placeholder in the environment create request payload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yanzhudd
approved these changes
Jan 27, 2026
Contributor
yanzhudd
left a comment
yanzhudd
left a comment
There was a problem hiding this comment.
it looks good to me.
thanks for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.