[App Config] az appconfig: Fix MSI auth for --auth-mode login parameter#30983
Merged
[App Config] az appconfig: Fix MSI auth for --auth-mode login parameter#30983
az appconfig: Fix MSI auth for --auth-mode login parameter#30983Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig --auth-mode loginDescription
Related to issue #30945
This change ensures that MSI auth works as expected.
Change was tested on azure VM to ensure authentication succeeds.
Since MI testing is not possible to on local dev devices, mocks were used to enable locally testing the code paths that result in
MSIAuthenticationWrapperbeing returned as the credential used for authentication, and was tested to ensure the expected method was called with the right scopes.Testing Guide
History Notes
[App Config]
az appconfig: Fix MSI auth for--auth-mode loginparameterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.