{Packaging} test-files.pythonhosted.org updated by azcliprod - #10241
Open
mansoor sarfraz (msarfraz) wants to merge 13 commits into
Open
{Packaging} test-files.pythonhosted.org updated by azcliprod#10241mansoor sarfraz (msarfraz) wants to merge 13 commits into
mansoor sarfraz (msarfraz) wants to merge 13 commits into
Conversation
mansoor sarfraz (msarfraz)
requested review from
FumingZhang,
Yu Chen (jsntcy),
Ethan Yang (necusjz),
ZelinWang (wangzelin007) and
Julie Zhu (yanzhudd)
as code owners
August 21, 2026 05:25
|
Hi mansoor sarfraz (@msarfraz), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
mansoor sarfraz (msarfraz)
August 21, 2026 05:27
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses network-isolation/SFI compliance by removing the non-compliant dependency on test-files.pythonhosted.org for the mixed-reality extension (v0.0.1) and updating test recordings so playback reflects the updated extension index payload.
Changes:
- Updated
mixed-realityv0.0.1downloadUrlin the extension index (src/index.json) to use theazcliprodblob-hosted wheel URL. - Updated multiple test recordings (Azure Firewall, Virtual WAN, AKS preview) containing the extension index payload to reflect the new
downloadUrl.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.json | Switches mixed-reality v0.0.1 downloadUrl to https://azcliprod.blob.core.windows.net/cli-extensions/... |
| src/virtual-wan/azext_vwan/tests/latest/recordings/test_routing_intent_crud.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/virtual-wan/azext_vwan/tests/latest/recordings/test_azure_vwan_route_table.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/azure-firewall/azext_firewall/tests/latest/recordings/test_firewall_with_route_server.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/azure-firewall/azext_firewall/tests/latest/recordings/test_firewall_vhub_create_with_public_ip.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/azure-firewall/azext_firewall/tests/latest/recordings/test_firewall_v2.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/azure-firewall/azext_firewall/tests/latest/recordings/test_firewall_basic_sku.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/azure-firewall/azext_firewall/tests/latest/recordings/test_azure_firewall_with_firewall_policy.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_extension_type_backup.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
| src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_extension_backup.yaml | Updates recorded extension index payload to the new blob-hosted mixed-reality URL |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Update cassette recordings to match current Network API version: - test_azure_firewall_with_firewall_policy.yaml (7 URLs) - test_firewall_basic_sku.yaml (12 URLs) - test_firewall_vhub_create_with_public_ip.yaml (4 URLs) This fixes VCR cassette matching failures due to API version mismatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Update cassette recordings to match current Network API version: - test_azure_firewall_with_firewall_policy.yaml (7 URLs) - test_firewall_basic_sku.yaml (12 URLs) - test_firewall_vhub_create_with_public_ip.yaml (4 URLs) This fixes VCR cassette matching failures due to API version mismatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Update all 10 Network API cassette recordings to use current API version. This fixes VCR cassette matching failures across all test suites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id cassette used the stale Microsoft.KeyVault vaults API version, causing VCR request matching failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The previous blanket 2024-07-01 -> 2025-07-01 replace was too broad. In azure-cli 2.89.1 different Network resource types are pinned to different API versions: - publicIPAddresses -> 2025-07-01 (was stale in cassettes) - virtualNetworks/subnets -> 2024-07-01 (correct, must not change) - vnet-create LRO polls -> 2024-07-01 (correct, must not change) Restore the recordings and re-apply the bump only to publicIPAddresses URIs plus the LRO polling URLs (azure-asyncoperation / location headers and their matching poll requests) belonging to those operations. Also reverts accidental corruption of unrelated response-body text in test_firewall_with_route_server.yaml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
test-files.pythonhosted.org -> azcliprod.blob.core.windows.net Scope limited to src/index.json only (per repo policy in scripts/ci/azdev_linter_style.py, index.json must not be combined with extension source/test changes in the same PR). The same dead URL also appears inside recorded HTTP response bodies in several extensions' test cassettes (aks-preview, azure-firewall, virtual-wan), but those are inert historical VCR fixtures (matched on request, not response body) and are left untouched to avoid unnecessarily triggering full integration-test re-validation for those extensions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Background
The following URL/Domain is marked non compliant by network isolation policy, S360 items were also raised to highlight it
Solution
This PR Updates the Azure CLI extensions index entry for mixed-reality v0.0.1 to use the azcliprod blob-hosted wheel instead of test-files.pythonhosted.org, and aligns the corresponding test recording to the same URL so playback matches the current index content.
Changes: