Skip to content

ValimailEnforce v3.0.1 - Company name misspelled#14368

Open
gborbollal wants to merge 3 commits into
Azure:masterfrom
ValiMail:valimailenforce-company-name-typo
Open

ValimailEnforce v3.0.1 - Company name misspelled#14368
gborbollal wants to merge 3 commits into
Azure:masterfrom
ValiMail:valimailenforce-company-name-typo

Conversation

@gborbollal
Copy link
Copy Markdown
Contributor

Required items, please complete

Change(s):

  • Fixed a typo in the "publisher" tags from Valimmail to Valimail in the following files: ValimailEnforceEventLogs_connectorDefinition.json and mainTemplate.json.

Reason for Change(s):

  • The company typo shows in the Sentinel Connector Configuration UI.

Version Updated:

  • Yes
  • See guidance below

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • The connector definition and the main template metadata were changed to fix the typo.

Testing Completed:

  • Yes/No/Need Help

@gborbollal gborbollal marked this pull request as ready for review May 28, 2026 19:32
@gborbollal gborbollal requested review from a team as code owners May 28, 2026 19:32
@v-maheshbh v-maheshbh self-assigned this May 29, 2026
@v-maheshbh v-maheshbh added the Solution Solution specialty review needed label May 29, 2026
@v-maheshbh v-maheshbh requested a review from Copilot May 29, 2026 09:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes a misspelling of the Valimail publisher name so the correct company name appears in the Microsoft Sentinel connector UI, and bumps the solution/package version accordingly.

Changes:

  • Corrected "publisher" from Valimmail to Valimail in connector UI configuration.
  • Bumped solution/package version references from 3.0.0 to 3.0.1.
  • Updated solution release notes for 3.0.1.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File Description
Solutions/ValimailEnforce/ReleaseNotes.md Adds a 3.0.1 entry describing the publisher-name typo fix.
Solutions/ValimailEnforce/Package/mainTemplate.json Updates packaged template metadata/version and fixes the publisher string in packaged connector UI config.
Solutions/ValimailEnforce/Data Connectors/ValimailEnforceEventLogs_ccp/ValimailEnforceEventLogs_connectorDefinition.json Fixes the publisher display name shown in the connector configuration UI.

Comment on lines +1 to +5
| **Version** | **Date Modified (DD-MM-YYYY)** | **Change History** |
|-------------|--------------------------------|---------------------------------------------|
| 3.0.0 | 22-04-2026 | Initial Solution Release |
|-------------|--------------------------------|---------------------------------------------|
| 3.0.1 | 28-05-2026 | Fix company name: Valimail instead Valimmail|
"_email": "[variables('email')]",
"_solutionName": "ValimailEnforce",
"_solutionVersion": "3.0.0",
"_solutionVersion": "3.0.1",
"_solutionId": "[variables('solutionId')]",
"workspaceResourceId": "[resourceId('microsoft.OperationalInsights/Workspaces', parameters('workspace'))]",
"dataConnectorCCPVersion": "3.0.0",
"dataConnectorCCPVersion": "3.0.1",
"id": "ValimailEnforceEventsConnector",
"title": "Valimail Enforce Configuration Events",
"publisher": "Valimmail",
"publisher": "Valimail",
"id": "ValimailEnforceEventsConnector",
"title": "Valimail Enforce Configuration Events",
"publisher": "Valimmail",
"publisher": "Valimail",
@gborbollal gborbollal requested a review from Copilot May 29, 2026 19:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Comment on lines +1 to +4
| **Version** | **Date Modified (DD-MM-YYYY)** | **Change History** |
|-------------|--------------------------------|-----------------------------------------------------|
| 3.0.1 | 28-05-2026 | Fix company name: use Valimail instead of Valimmail |
| 3.0.0 | 22-04-2026 | Initial Solution Release |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants