refactor: migrate bootstrapper to components api#96
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wenxuan0923
reviewed
Feb 26, 2026
| @@ -1,8 +1,11 @@ | |||
| package components | |||
|
|
|||
| import ( | |||
Collaborator
There was a problem hiding this comment.
I'm wondering if we add multiple versions of the same action in the future, do I need to register all with the hub? I assume not, since the action protobuf in unversioned, right?
Member
Author
There was a problem hiding this comment.
I think we will have a step to convert into unversioned model. But I don't see the necessary to implement that layer at this moment, so i just assume the v20260301 is the base "unversioned" model for now.
| @@ -0,0 +1,54 @@ | |||
| [Unit] | |||
| Description=Kubelet | |||
Collaborator
There was a problem hiding this comment.
So KubadmNodeJoin action cannot coexist with StartKubeletService action, do we have a way to enforce that?
Member
Author
There was a problem hiding this comment.
this is on caller to make sure the sequence/actions selected will be working
bcho
commented
Feb 26, 2026
wenxuan0923
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thsi pull request refactored the bootstrapper steps to use components API. We also migrated the kubelet start and cni steps to components API. Unused bootstrapper steps are removed as part of the PR.