Skip to content

Updating biceps to provide support for passing an existing ACR#40

Draft
trangevi wants to merge 5 commits intomainfrom
trangevi/existing-acr
Draft

Updating biceps to provide support for passing an existing ACR#40
trangevi wants to merge 5 commits intomainfrom
trangevi/existing-acr

Conversation

@trangevi
Copy link
Collaborator

Purpose

Trying to add handling so that if a user provides the necessary ACR information, we'll just create a connection to the project instead of creating a new ACR

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Added parameters for existing container registry and endpoint.

Signed-off-by: Travis Angevine <trangevi@microsoft.com>
Added parameters for existing container registry.

Signed-off-by: Travis Angevine <trangevi@microsoft.com>
Added support for existing container registry connections and enhanced resource provisioning logic.

Signed-off-by: Travis Angevine <trangevi@microsoft.com>
Signed-off-by: Travis Angevine <trangevi@microsoft.com>
This Bicep file defines a role assignment for granting the AcrPull role to a specified principal in an existing Azure Container Registry.

Signed-off-by: Travis Angevine <trangevi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments