Skip to content

test: flag e2e_multi_validator_node_key_store P2P tx-dropped failure as flake#23528

Merged
alexghr merged 1 commit into
merge-train/spartanfrom
cb/04678745050b
May 23, 2026
Merged

test: flag e2e_multi_validator_node_key_store P2P tx-dropped failure as flake#23528
alexghr merged 1 commit into
merge-train/spartanfrom
cb/04678745050b

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Summary

Add a .test_patterns.yml entry to flag the multi-validator web3signer suite as a flake when the first concurrently-submitted tx is dropped by the P2P layer before reaching a proposer. This is what dequeued PR #23344 from the merge queue at 2026-05-23T09:17 (run 26328618812).

Investigation

Jest output:

FAIL src/composed/web3signer/e2e_multi_validator_node_key_store.test.ts
  e2e_multi_validator_node
    ✕ should build blocks & attest with multiple validator keys (129296 ms)

  ● e2e_multi_validator_node › should build blocks & attest with multiple validator keys

    Transaction 0x26a078118c6ca2566de5b2405b745cc211dfd53a9bdcd478d068c2e13994a6a3 was dropped. Reason: Tx dropped by P2P node

      at async Promise.all (index 0)
      at Object.<anonymous> (composed/web3signer/e2e_multi_validator_node_key_store.test.ts:410:33)

Line 410 is inside the await Promise.all(sentTransactionPromises.map(async … => waitForTx(aztecNode, txHash))) block. The first of the concurrently-submitted txs never propagates and waitForTx resolves to a dropped receipt; this is a transient P2P-propagation flake under the proposer-pipelining migration in #23482.

Why a new entry?

There is no existing entry covering this suite. The unique error signature is Tx dropped by P2P node, which appears in the receipt's error field rendered by waitForTx.

Follow-up

Proper fix: investigate why the first tx is occasionally dropped before propagation completes (likely a race between mempool insertion and proposer pickup under pipelining). Same family as the other merge-train/spartan pipelining flakes; owner palla is the author of the pipelining migration (#23482, which also migrated this suite).

Test plan

  • error_regex: "Tx dropped by P2P node" matches the observed receipt error
  • CI continues to run src/composed/web3signer/e2e_multi_validator_node_key_store.test.ts; the P2P-drop failure now alerts palla on #aztec3-ci instead of failing the build

Created by claudebox · group: slackbot

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label May 23, 2026
@alexghr alexghr marked this pull request as ready for review May 23, 2026 14:00
@alexghr alexghr enabled auto-merge (squash) May 23, 2026 14:00
@alexghr alexghr merged commit 735cfae into merge-train/spartan May 23, 2026
44 of 51 checks passed
@alexghr alexghr deleted the cb/04678745050b branch May 23, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-skip claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants