test: flag e2e_multi_validator_node_key_store P2P tx-dropped failure as flake#23528
Merged
Conversation
alexghr
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
.test_patterns.ymlentry to flag the multi-validator web3signer suite as a flake when the first concurrently-submitted tx is dropped by the P2P layer before reaching a proposer. This is what dequeued PR #23344 from the merge queue at 2026-05-23T09:17 (run 26328618812).Investigation
cijob: https://github.com/AztecProtocol/aztec-packages/actions/runs/26328618812/job/77510713955Jest output:
Line 410 is inside the
await Promise.all(sentTransactionPromises.map(async … => waitForTx(aztecNode, txHash)))block. The first of the concurrently-submitted txs never propagates andwaitForTxresolves to a dropped receipt; this is a transient P2P-propagation flake under the proposer-pipelining migration in #23482.Why a new entry?
There is no existing entry covering this suite. The unique error signature is
Tx dropped by P2P node, which appears in the receipt'serrorfield rendered bywaitForTx.Follow-up
Proper fix: investigate why the first tx is occasionally dropped before propagation completes (likely a race between mempool insertion and proposer pickup under pipelining). Same family as the other
merge-train/spartanpipelining flakes; owner palla is the author of the pipelining migration (#23482, which also migrated this suite).Test plan
error_regex: "Tx dropped by P2P node"matches the observed receipt errorsrc/composed/web3signer/e2e_multi_validator_node_key_store.test.ts; the P2P-drop failure now alerts palla on#aztec3-ciinstead of failing the buildCreated by claudebox · group:
slackbot