test(e2e): require cross-observer agreement on sentinel fault slot#23513
Merged
Conversation
PhilWindle
approved these changes
May 22, 2026
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #23344 (merge-train/spartan) was dequeued because
e2e_p2p/sentinel_status_slash.parallel.test.ts"slashes the proposer with INACTIVITY when checkpoint validation records invalid" flaked in shardci/x3-full(run, log).From the failing log:
14:36:28malicious validator-1 broadcasts INVALID checkpoint for slot 1114:37:24only validator-2 recordscheckpoint-invalidat slot 1114:38:29–31when the malicious node is selected again at slot 27, validators 2/3/4/5/6 all recordcheckpoint-invalidat slot 27TimeoutError: Timeout awaiting sentinel status for 0x90f7…906 at slot 11findObservedStatusSlotwas polling onlyhonestObservers[0](validator-2), which had picked up the malicious proposer's gossip earlier than the other observers. It returned slot 11.assertAllObserversSentinelStatusthen timed out polling the rest of the observers for a slot they had never recorded — they only recordedcheckpoint-invalidat the next occurrence (slot 27).What
Change
findObservedStatusSlotto require cross-observer agreement: it now takes the fullobserverNodeslist and returns the earliest slot where every honest observer has recordedexpectedStatus. That guarantees the downstreamassertAllObserversSentinelStatuscall has a slot every observer can satisfy.Times out — and fails — if no common fault slot is ever recorded, so a genuine detection failure is still caught.
Both flake-prone tests (
checkpoint-unvalidatedandcheckpoint-invalid) use the same helper and benefit equally.Created by claudebox · group:
slackbot