feat(keybinds): add keybind for PAM U2F on lock screen - #2930
Merged
Conversation
Purian23
requested changes
Aug 2, 2026
Purian23
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR, a keyboard option is warranted. A few items:
We can't merge a hardcoded Ctrl+Q in this sense. The passkey button already calls startForAlternativeAuth(), and compositor keybinds don't reliably work on the lock screen anyway.
Please rework to:
- Shared helper (e.g.
triggerSecurityKeyUnlock()) used by both the button and keyboard handler, gated bycanStartSecurityKeyUnlock() - Lock Screen setting for the shortcut or a documented default with a UI hint
- Key handler inside the existing Ctrl-only modifier block
Happy to re-review once that's in.
nozsh
force-pushed
the
lockscreen-hw-keybind
branch
from
August 3, 2026 17:23
44232ee to
8254c1e
Compare
Contributor
Author
Collaborator
|
Thanks, looks good. I added a few QOL adjustments and the missing settings json. Should be good to go. |
Purian23
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds keybind to trigger PAM U2F authentication on lock screen via Ctrl+Q
Type of change
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings