Skip to content

feat(keybinds): add keybind for PAM U2F on lock screen - #2930

Merged
Purian23 merged 2 commits into
AvengeMedia:masterfrom
nozsh:lockscreen-hw-keybind
Aug 4, 2026
Merged

feat(keybinds): add keybind for PAM U2F on lock screen#2930
Purian23 merged 2 commits into
AvengeMedia:masterfrom
nozsh:lockscreen-hw-keybind

Conversation

@nozsh

@nozsh nozsh commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Description

Adds keybind to trigger PAM U2F authentication on lock screen via Ctrl+Q

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

@Purian23 Purian23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, a keyboard option is warranted. A few items:

We can't merge a hardcoded Ctrl+Q in this sense. The passkey button already calls startForAlternativeAuth(), and compositor keybinds don't reliably work on the lock screen anyway.

Please rework to:

  • Shared helper (e.g. triggerSecurityKeyUnlock()) used by both the button and keyboard handler, gated by canStartSecurityKeyUnlock()
  • Lock Screen setting for the shortcut or a documented default with a UI hint
  • Key handler inside the existing Ctrl-only modifier block

Happy to re-review once that's in.

@nozsh
nozsh force-pushed the lockscreen-hw-keybind branch from 44232ee to 8254c1e Compare August 3, 2026 17:23
@nozsh

nozsh commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for advice. Done, I hope this is exactly what you meant.

In settings it looks like this:

screenshot

@nozsh
nozsh requested a review from Purian23 August 3, 2026 17:43
@Purian23

Purian23 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks, looks good. I added a few QOL adjustments and the missing settings json. Should be good to go.

@Purian23
Purian23 merged commit 6de5593 into AvengeMedia:master Aug 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants