Repository navigation
fix(daemon): log host disk-full side-effect failures at warn level - #66
Merged
sagnik11 merged 3 commits intoOct 8, 2026
Conversation
A full disk on the user's machine (io ErrorKind::StorageFull, ENOSPC) made the side-effect failure sites log at ERROR level, so the SentryLayer reported it as an AutterError exception. Add is_storage_full_error and log these failures at warn level instead. The daemon still records the side-effect error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 5ce83de7-5076-4c53-ba66-d8252b6f4349
Both side-effect failure sites had the same warn-or-error block. Move it into log_side_effect_error. SentryLayer reads only the event level, so the change does not affect error grouping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 5ce83de7-5076-4c53-ba66-d8252b6f4349
…ssifiers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sagnik11
marked this pull request as ready for review
October 8, 2026 22:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ingest_trace_payload_fastand the command side-effect path log every side-effect failure withtracing::error!.SentryLayerturns each ERROR event into anAutterErrorexception.is_missing_working_dir_error, matches vanished temp repos. It does not matchstd::io::ErrorKind::StorageFull(ENOSPC on Unix,ERROR_DISK_FULLon Windows).Changes
is_storage_full_errorclassifier selects host disk-full errors. At the two side-effect failure sites, these errors now log at warn level, andSentryLayerdoes not capture warn-level events.record_side_effect_error, so family state still shows the failure. Only the log level changes....: host disk is full), so the logs show this environment cause clearly.async side-effect errorcommand side effect failedNote
Out of scope: the
async completion log write failedsites can also fail on a full disk, but this change does not touch them. Also, this change does not overlap #64, which widensis_missing_working_dir_errorfor missing git objects. The two changes edit different functions and can merge in any order.Testing
cargo test --locked --lib -- storage_full_error missing_working_dir_error: 5 passed. This includes the newstorage_full_error_detects_disk_full_io_errorstest, which uses raw os error 28 on Unix.cargo fmt --check: clean.cargo clippy --locked --lib: no new warnings. The existing warnings are on lines that this change does not touch.task testdaemon-mode suite. CI runs it.Agent context
autter-monorepo, but the daemon code is in this repo.maybe_apply_side_effects_for_applied_command, as the code does for vanished directories. That would returnOkand hide a real side-effect failure from family state. A lower log level keeps the record and removes only the noise.Created with PostHog Desktop from this inbox report.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.