fix(cli): classify runtime input materialization crashes - #2503
Merged
Conversation
Empty extra_plugins still boots Playground while mounting recipe inputs. A crash in that window had no phase, so runs classified as unknown. Track it as materialize_runtime_inputs and reject PHP.wasm side modules whose ABI imports the runtime does not export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mount_plugins(input mounts, staged files, Playground boot/materialize) asmaterialize_runtime_inputs, including whenextra_pluginsis empty.unknown/execution.php_*,zend_*,convert_to_*,_emalloc_*, …) that the selected PHP.wasm build does not export. That is theTypeError: resolved is not a functionComlink path: Emscripten installs a lazy stub that callsresolved(...args)afterresolveSymbolreturns undefined.Test plan
tests/recipe-runtime-setup-empty-plugins.test.ts— empty extra plugin list still materializes file input mounts; aresolved is not a functionthrow is recorded as a failedmaterialize_runtime_inputsphase.tests/php-wasm-extension-abi.test.ts— missingphp_password_algo_register/_emalloc_448fail closed; Emscripten libc imports are ignored.npm run checkAI assistance: GPT-6 Astra via OpenCode diagnosed the preceding blockers; Grok 4.6 via
opencode runroot-caused this crash, implemented the fix, and ran the suites.